Set scissor to clip bounding box when using GrConvexPolyEffect

src/gpu/GrClipMaskManager.cpp

 
 /*
  * Copyright 2012 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "GrClipMaskManager.h"
 #include "GrAAConvexPathRenderer.h"
@@ skipping 156 matching lines @@
                 effect.reset(GrConvexPolyEffect::Create(GrConvexPolyEffect::kFillNoAA_EdgeType, p));
             }
         } else {
             GrConvexPolyEffect::EdgeType type = isAA ? GrConvexPolyEffect::kFillAA_EdgeType :
                                                        GrConvexPolyEffect::kFillNoAA_EdgeType;
             effect.reset(GrConvexPolyEffect::Create(type, p));
         }
         if (effect) {
             are->set(fGpu->drawState());
             fGpu->drawState()->addCoverageEffect(effect);
-            fGpu->disableScissor();
+            SkIRect scissorSpaceIBounds(clipSpaceIBounds);

[bsalomon, 2014/02/06 22:16:01]

It turns out we were already doing this in the stencil mask case.

This reminds me that the path is not always in device space due to save layer
offsets. I'll prepare another CL with a test and fix.

[robertphillips, 2014/02/07 13:42:11]

That's a better answer then them analyzing our stencil buffer usage.

+            scissorSpaceIBounds.offset(-clipDataIn->fOrigin);
+            fGpu->enableScissor(scissorSpaceIBounds);
             this->setGpuStencil();
             return true;
         }
     }
 
 #if GR_AA_CLIP
     // If MSAA is enabled we can do everything in the stencil buffer.
     if (0 == rt->numSamples() && requiresAA) {
         GrTexture* result = NULL;
 
@@ skipping 872 matching lines @@
 
     // TODO: dynamically attach a stencil buffer
     int stencilBits = 0;
     GrStencilBuffer* stencilBuffer =
         drawState.getRenderTarget()->getStencilBuffer();
     if (NULL != stencilBuffer) {
         stencilBits = stencilBuffer->bits();
         this->adjustStencilParams(settings, clipMode, stencilBits);
     }
 }