Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1568303002: Renamed check for requiring ShadowPseudo combinator. (Closed)

Created:
4 years, 11 months ago by rune
Modified:
4 years, 11 months ago
Reviewers:
Timothy Loh, esprehn
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renamed check for requiring ShadowPseudo combinator. Some selectors have an implicit boundary crossing combinator inside what is a compound selector in the selector text. This is an implementation detail, but we insert such combinators for our SelectorChecker to switch scopes during matching. Example: input::-webkit-clear-button This is a compund selector matching a pseudo element inside the input's shadow tree. In the implementation, we store that as: input /implicit-shadow-crossing-combinator/ ::-webkit-clear-button Where the pseudo element simple selector will match the element inside the shadow tree, and the implicit combinator will act as a descendant combinator that can reach into the shadow so that we make the way up to matching the input type selector on the host element. Here, we rename methods in the selector parser to reflect that and make the code easier to understand. There should be no behavioral changes. R=timloh@chromium.org,esprehn@chromium.org Committed: https://crrev.com/d8ec75e351cfb52ffb1ff9550ca4d4462fda53b4 Cr-Commit-Position: refs/heads/master@{#368548}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSParserSelector.h View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp View 4 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568303002/1
4 years, 11 months ago (2016-01-08 13:34:35 UTC) #2
rune
ptal
4 years, 11 months ago (2016-01-08 13:34:47 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-08 15:21:53 UTC) #5
Timothy Loh
On 2016/01/08 13:34:47, rune wrote: > ptal lgtm
4 years, 11 months ago (2016-01-11 01:42:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568303002/1
4 years, 11 months ago (2016-01-11 07:33:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-11 09:15:16 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 09:17:35 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8ec75e351cfb52ffb1ff9550ca4d4462fda53b4
Cr-Commit-Position: refs/heads/master@{#368548}

Powered by Google App Engine
This is Rietveld 408576698