Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSParserSelector.h

Issue 1568303002: Renamed check for requiring ShadowPseudo combinator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/parser/CSSParserSelector.h
diff --git a/third_party/WebKit/Source/core/css/parser/CSSParserSelector.h b/third_party/WebKit/Source/core/css/parser/CSSParserSelector.h
index 47171cf2a9e8a8bbfc933ad9779a5fbbee142521..21d8dee4d7dc20d6d52951866896df128210e61f 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSParserSelector.h
+++ b/third_party/WebKit/Source/core/css/parser/CSSParserSelector.h
@@ -58,11 +58,10 @@ public:
CSSSelector::PseudoType pseudoType() const { return m_selector->pseudoType(); }
- // TODO(esprehn): This set of cases doesn't make sense, why PseudoShadow but not a check for ::content or /deep/ ?
- bool crossesTreeScopes() const { return pseudoType() == CSSSelector::PseudoWebKitCustomElement || pseudoType() == CSSSelector::PseudoCue || pseudoType() == CSSSelector::PseudoShadow; }
+ bool needsImplicitShadowCrossingCombinatorForMatching() const { return pseudoType() == CSSSelector::PseudoWebKitCustomElement || pseudoType() == CSSSelector::PseudoCue || pseudoType() == CSSSelector::PseudoShadow; }
bool isSimple() const;
- bool hasShadowPseudo() const;
+ bool hasImplicitShadowCrossingCombinatorForMatching() const;
CSSParserSelector* tagHistory() const { return m_tagHistory.get(); }
void setTagHistory(PassOwnPtr<CSSParserSelector> selector) { m_tagHistory = selector; }
@@ -76,7 +75,7 @@ private:
OwnPtr<CSSParserSelector> m_tagHistory;
};
-inline bool CSSParserSelector::hasShadowPseudo() const
+inline bool CSSParserSelector::hasImplicitShadowCrossingCombinatorForMatching() const
{
return m_selector->relation() == CSSSelector::ShadowPseudo;
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698