Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1312)

Issue 1568213004: Use the force_software_compositing flag in the Widget::InitParams structure instead of the TYPE_MEN… (Closed)

Created:
4 years, 11 months ago by ananta
Modified:
4 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the force_software_compositing flag in the Widget::InitParams structure instead of the TYPE_MENU window type, to determine if we should use a top level window. For more context please refer to the following change https://codereview.chromium.org/1380973003. This appears to have caused perf regressions on non Aero bots. The only thing which pops out here is that the above change caused the omnibox and status window to be non top level windows. Retain the WS_EX_COMPOSITED style for software composited translucent windows when Aero is off. This ensures that the window paints correctly. BUG=540521 TEST=Run chrome with the --disable-dwm-composition switch. Type in the omnibox. It should look good. Committed: https://crrev.com/21d7aae2abdfbaf2f7e25edc25b775e9a7265fb9 Cr-Commit-Position: refs/heads/master@{#368673}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/ui/views/chrome_views_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/widget_hwnd_utils.cc View 1 chunk +4 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
ananta
4 years, 11 months ago (2016-01-09 02:46:19 UTC) #3
sky
LGTM
4 years, 11 months ago (2016-01-11 16:22:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568213004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568213004/1
4 years, 11 months ago (2016-01-11 20:26:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-11 21:35:58 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 21:37:10 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21d7aae2abdfbaf2f7e25edc25b775e9a7265fb9
Cr-Commit-Position: refs/heads/master@{#368673}

Powered by Google App Engine
This is Rietveld 408576698