Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: chrome/browser/ui/views/chrome_views_delegate.cc

Issue 1568213004: Use the force_software_compositing flag in the Widget::InitParams structure instead of the TYPE_MEN… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/widget/widget_hwnd_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/chrome_views_delegate.cc
diff --git a/chrome/browser/ui/views/chrome_views_delegate.cc b/chrome/browser/ui/views/chrome_views_delegate.cc
index 72f24013ba6cce44e1866d5699f7c2ec34928011..03ff778af900c14e8303b77ac37ac3e68f05489c 100644
--- a/chrome/browser/ui/views/chrome_views_delegate.cc
+++ b/chrome/browser/ui/views/chrome_views_delegate.cc
@@ -333,7 +333,7 @@ void ChromeViewsDelegate::OnBeforeWidgetInit(
#if defined(USE_AURA) && !defined(OS_CHROMEOS)
bool use_non_toplevel_window =
params->parent &&
- params->type != views::Widget::InitParams::TYPE_MENU &&
+ !params->force_software_compositing &&
params->type != views::Widget::InitParams::TYPE_TOOLTIP;
#if defined(OS_WIN)
@@ -357,7 +357,7 @@ void ChromeViewsDelegate::OnBeforeWidgetInit(
// transparency will be broken with a toplevel window, so force the use of
// a non toplevel window.
if (params->opacity == views::Widget::InitParams::TRANSLUCENT_WINDOW &&
- params->type != views::Widget::InitParams::TYPE_MENU)
+ !params->force_software_compositing)
use_non_toplevel_window = true;
} else {
// If we're on Vista+ with composition enabled, then we can use toplevel
« no previous file with comments | « no previous file | ui/views/widget/widget_hwnd_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698