Issue 15682004: Remove the network config dialog extra border.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15682004: Remove the network config dialog extra border. (Closed)

Created:
7 years, 7 months ago by msw

Modified:
7 years, 7 months ago

Reviewers:
msw, sky

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, James Cook, Nikita (slow), stevenjb, Charlie Lee

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove the network config dialog extra border. NetworkConfigView uses Widget::CreateWindow. Use DialogDelegate::CreateDialogWidget instead. Also override GetWindowTitle using the child views' info. (these dialogs were previously using custom title labels) See before/after pics at http://crbug.com/166075#c101 Trigger by joining WiFi/VPN/WiMax networks on Chrome OS. BUG=166075 TEST=Network config dialogs look good with the new and old style. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202153

Patch Set 1 #

Patch Set 2 : Also fix the network config view titles. #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -32 lines)			Patch
M	chrome/browser/chromeos/options/network_config_view.h	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/options/network_config_view.cc	View	1	2 chunks	+7 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/options/vpn_config_view.h	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/options/vpn_config_view.cc	View	1	3 chunks	+11 lines, -10 lines	0 comments	Download
M	chrome/browser/chromeos/options/wifi_config_view.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/options/wifi_config_view.cc	View	1	2 chunks	+4 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/options/wimax_config_view.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/options/wimax_config_view.cc	View	1	2 chunks	+5 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/15682004/2001

7 years, 7 months ago (2013-05-24 16:24:04 UTC) #3

Message was sent while issue was closed.

Change committed as 202153

Expand Messages | Collapse Messages