mojo/shell/connect_to_application_params.cc - Issue 1568073002: Reduce string copies in GURL creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/shell/connect_to_application_params.cc

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mac Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/shell/connect_to_application_params.cc

diff --git a/mojo/shell/connect_to_application_params.cc b/mojo/shell/connect_to_application_params.cc

index e631617b9323c5562f4688b76d64b63b3341837d..9d7c3a469f80afbf9b398673335792e7baa3a06a 100644

--- a/mojo/shell/connect_to_application_params.cc

+++ b/mojo/shell/connect_to_application_params.cc

@@ -37,8 +37,8 @@ void ConnectToApplicationParams::SetTargetURL(const GURL& target_url) {

}

void ConnectToApplicationParams::SetTargetURLRequest(URLRequestPtr request) {

- Identity target = request ? Identity(GURL(request->url), target_.qualifier(),

- target_.filter())

+ Identity target = request ? Identity(GURL(request->url.get()),

+ target_.qualifier(), target_.filter())

: Identity();

SetTargetURLRequest(std::move(request), target);

}