media/blink/key_system_config_selector.cc - Issue 1568073002: Reduce string copies in GURL creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/key_system_config_selector.cc

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mac Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/blink/key_system_config_selector.cc

diff --git a/media/blink/key_system_config_selector.cc b/media/blink/key_system_config_selector.cc

index 414a66252ed29d7700fde4b71de0fe98980fcc25..87b3f83675450af5133311e0a7eb53d80970e199 100644

--- a/media/blink/key_system_config_selector.cc

+++ b/media/blink/key_system_config_selector.cc

@@ -765,7 +765,8 @@ void KeySystemConfigSelector::SelectConfigInternal(

{

// Note: the GURL must not be constructed inline because

// base::Passed(&request) sets |request| to null.

- GURL security_origin(request->security_origin.toString());

+ GURL security_origin(

+ base::string16(request->security_origin.toString()));

media_permission_->RequestPermission(

MediaPermission::PROTECTED_MEDIA_IDENTIFIER, security_origin,

base::Bind(&KeySystemConfigSelector::OnPermissionResult,