Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1281)

Unified Diff: content/renderer/render_view_impl.cc

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mac Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 00c278e9debd13901b9162cceacf0ac203057a2b..cb25629a566ebe1593f72b7d3262ab8ba66e22ff 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -51,6 +51,7 @@
#include "content/common/site_isolation_policy.h"
#include "content/common/ssl_status_serialization.h"
#include "content/common/view_messages.h"
+#include "content/public/child/url_conversion.h"
#include "content/public/common/bindings_policy.h"
#include "content/public/common/content_client.h"
#include "content/public/common/content_constants.h"
@@ -316,8 +317,9 @@ static RenderViewImpl* (*g_create_render_view_impl)(
Referrer RenderViewImpl::GetReferrerFromRequest(
WebFrame* frame,
const WebURLRequest& request) {
- return Referrer(GURL(request.httpHeaderField(WebString::fromUTF8("Referer"))),
- request.referrerPolicy());
+ return Referrer(
+ WebStringToGURL(request.httpHeaderField(WebString::fromUTF8("Referer"))),
+ request.referrerPolicy());
}
// static
@@ -1606,10 +1608,11 @@ WebView* RenderViewImpl::createView(WebLocalFrame* creator,
params.opener_top_level_frame_url = creator->top()->document().url();
} else {
params.opener_top_level_frame_url =
- GURL(creator->top()->securityOrigin().toString());
+ WebStringToGURL(creator->top()->securityOrigin().toString());
}
- GURL security_url(creator->document().securityOrigin().toString());
+ GURL security_url(WebStringToGURL(
+ creator->document().securityOrigin().toString()));
if (!security_url.is_valid())
security_url = GURL();
params.opener_security_origin = security_url;

Powered by Google App Engine
This is Rietveld 408576698