Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Side by Side Diff: content/public/child/url_conversion.cc

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mac Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "base/strings/string_piece.h"
6 #include "third_party/WebKit/public/platform/WebString.h"
7 #include "url/gurl.h"
8
9 namespace content {
10
11 GURL WebStringToGURL(const blink::WebString& web_string) {
12 if (web_string.is8Bit()) {
13 return GURL(base::StringPiece(
14 reinterpret_cast<const char*>(web_string.data8OrNull()),
esprehn 2016/01/08 02:12:50 I'm not sure if this is right, the 8 bit data is n
15 web_string.length()));
16 } else {
17 return GURL(base::StringPiece16(
18 static_cast<const base::char16*>(web_string.data16OrNull()),
19 web_string.length()));
20 }
21 }
22
23 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698