Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/child/notifications/notification_data_conversions.cc

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mac Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/permissions/permission_service_impl.cc ('k') | content/child/notifications/notification_manager.cc » ('j') | content/public/child/url_conversion.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/notifications/notification_data_conversions.cc
diff --git a/content/child/notifications/notification_data_conversions.cc b/content/child/notifications/notification_data_conversions.cc
index 63f570f7388218d4d1209e325249ded44c49cd5c..88b6178c80a32562ee86bdbf2b6dbbf98dc4dc80 100644
--- a/content/child/notifications/notification_data_conversions.cc
+++ b/content/child/notifications/notification_data_conversions.cc
@@ -7,6 +7,7 @@
#include <stddef.h>
#include "base/strings/utf_string_conversions.h"
+#include "content/public/child/url_conversion.h"
#include "third_party/WebKit/public/platform/WebString.h"
#include "third_party/WebKit/public/platform/WebURL.h"
#include "third_party/WebKit/public/platform/WebVector.h"
@@ -38,7 +39,7 @@ PlatformNotificationData ToPlatformNotificationData(
platform_data.lang = base::UTF16ToUTF8(base::StringPiece16(web_data.lang));
platform_data.body = web_data.body;
platform_data.tag = base::UTF16ToUTF8(base::StringPiece16(web_data.tag));
- platform_data.icon = GURL(web_data.icon.string());
+ platform_data.icon = WebStringToGURL(web_data.icon.string());
platform_data.vibration_pattern.assign(web_data.vibrate.begin(),
web_data.vibrate.end());
platform_data.silent = web_data.silent;
« no previous file with comments | « content/browser/permissions/permission_service_impl.cc ('k') | content/child/notifications/notification_manager.cc » ('j') | content/public/child/url_conversion.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698