mandoline/services/updater/updater_impl.cc - Issue 1568073002: Reduce string copies in GURL creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mandoline/services/updater/updater_impl.cc

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mandoline/services/updater/updater_impl.cc

diff --git a/mandoline/services/updater/updater_impl.cc b/mandoline/services/updater/updater_impl.cc

index 9b40ec07717c325d5a83cf45ed6184653b977240..ca27c46c5e90a6ed1f6172494ea79f17620c4f7b 100644

--- a/mandoline/services/updater/updater_impl.cc

+++ b/mandoline/services/updater/updater_impl.cc

@@ -31,7 +31,7 @@ void UpdaterImpl::GetPathForApp(

// integration with components/update_client.

base::FilePath shell_dir;

PathService::Get(base::DIR_MODULE, &shell_dir);

- const GURL as_url(url);

+ const GURL as_url(url.get());

const base::FilePath path = shell_dir.Append(base::FilePath::FromUTF8Unsafe(

as_url.path().substr(2, as_url.path().size() - 3) + ".mojo"));

callback.Run(path.AsUTF8Unsafe());