components/autofill/content/renderer/form_autofill_util.cc - Issue 1568073002: Reduce string copies in GURL creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/form_autofill_util.cc

Issue 1568073002: Reduce string copies in GURL creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/content/renderer/form_autofill_util.cc

diff --git a/components/autofill/content/renderer/form_autofill_util.cc b/components/autofill/content/renderer/form_autofill_util.cc

index 1655f1abcb6bc6408fd7f29e55b85fcc522da809..ee129154b9853c6ba95f42be16d19f001fdaed5c 100644

--- a/components/autofill/content/renderer/form_autofill_util.cc

+++ b/components/autofill/content/renderer/form_autofill_util.cc

@@ -1420,7 +1420,7 @@ bool WebFormElementToFormData(

// If the completed URL is not valid, just use the action we get from

// WebKit.

if (!form->action.is_valid())

- form->action = GURL(form_element.action());

+ form->action = GURL(base::string16(form_element.action()));

WebVector<WebFormControlElement> control_elements;

form_element.getFormControlElements(control_elements);