Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1568063002: Revert of Fix handling of radii scaling to force the result to always be less (Closed)

Created:
4 years, 11 months ago by robertphillips
Modified:
4 years, 11 months ago
Reviewers:
herb_g, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Fix handling of radii scaling to force the result to always be less (patchset #14 id:250001 of https://codereview.chromium.org/1567723004/ ) Reason for revert: Fear and doubt of NexusPlayer Original issue's description: > Fix handling of radii scaling to force the result to always be less > than a given side. > BUG=472147 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1567723004 > > Committed: https://skia.googlesource.com/skia/+/f96bf1a2d091a917bb93f9e9a3a8d53bb39d068e TBR=reed@google.com,herb@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=472147 Committed: https://skia.googlesource.com/skia/+/1243b702eed1fa6f37da7d3ce71f41b4bc45ea7c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -91 lines) Patch
M src/core/SkRRect.cpp View 4 chunks +43 lines, -56 lines 0 comments Download
M tests/DrawPathTest.cpp View 2 chunks +0 lines, -35 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
robertphillips
Created Revert of Fix handling of radii scaling to force the result to always be ...
4 years, 11 months ago (2016-01-07 22:17:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568063002/1
4 years, 11 months ago (2016-01-07 22:17:14 UTC) #2
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 22:17:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1243b702eed1fa6f37da7d3ce71f41b4bc45ea7c

Powered by Google App Engine
This is Rietveld 408576698