Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1567963002: [builtins] Migrate Object.keys to C++. (Closed)

Created:
4 years, 11 months ago by Benedikt Meurer
Modified:
4 years, 11 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Migrate Object.keys to C++. Everything necessary to implement Object.keys efficiently is already available in C++ land for quite some time now, and only the thin JavaScript wrapper was left, so get rid of that as well and move the whole builtin to C++ instead. R=yangguo@chromium.org Committed: https://crrev.com/50e1e751c6d71e0cd46c85cd699b65a71b1f2fe9 Cr-Commit-Position: refs/heads/master@{#33167}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -18 lines) Patch
M src/bootstrapper.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/builtins.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M src/contexts.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/execution.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/execution.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/js/json.js View 4 chunks +2 lines, -4 lines 0 comments Download
M src/js/v8natives.js View 3 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 11 months ago (2016-01-07 18:47:17 UTC) #1
Benedikt Meurer
Hey Yang, Some cleanup for Object.keys. Please take a look. Thanks, Benedikt
4 years, 11 months ago (2016-01-07 18:47:47 UTC) #2
Yang
On 2016/01/07 18:47:47, Benedikt Meurer wrote: > Hey Yang, > > Some cleanup for Object.keys. ...
4 years, 11 months ago (2016-01-08 06:36:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1567963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1567963002/1
4 years, 11 months ago (2016-01-08 06:37:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 06:40:24 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 06:41:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50e1e751c6d71e0cd46c85cd699b65a71b1f2fe9
Cr-Commit-Position: refs/heads/master@{#33167}

Powered by Google App Engine
This is Rietveld 408576698