Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: src/js/v8natives.js

Issue 1567963002: [builtins] Migrate Object.keys to C++. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/js/json.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/v8natives.js
diff --git a/src/js/v8natives.js b/src/js/v8natives.js
index c25eb8069dab4f0912bf2fea6d1eca0d3bfc0ddb..f480d6819a98900238183d439ca6cc4586b8411a 100644
--- a/src/js/v8natives.js
+++ b/src/js/v8natives.js
@@ -211,13 +211,6 @@ function ObjectLookupSetter(name) {
}
-function ObjectKeys(obj) {
- obj = TO_OBJECT(obj);
- var filter = PROPERTY_FILTER_ONLY_ENUMERABLE | PROPERTY_FILTER_SKIP_SYMBOLS;
- return %GetOwnPropertyKeys(obj, filter);
-}
-
-
// ES6 6.2.4.1
function IsAccessorDescriptor(desc) {
if (IS_UNDEFINED(desc)) return false;
@@ -892,7 +885,7 @@ utils.InstallGetterSetter(GlobalObject.prototype, "__proto__", ObjectGetProto,
// Set up non-enumerable functions in the Object object.
utils.InstallFunctions(GlobalObject, DONT_ENUM, [
// assign is added in bootstrapper.cc.
- "keys", ObjectKeys,
+ // keys is added in bootstrapper.cc.
"defineProperty", ObjectDefineProperty,
"defineProperties", ObjectDefineProperties,
"getPrototypeOf", ObjectGetPrototypeOf,
@@ -1210,7 +1203,6 @@ utils.Export(function(to) {
to.ObjectDefineProperties = ObjectDefineProperties;
to.ObjectDefineProperty = ObjectDefineProperty;
to.ObjectHasOwnProperty = ObjectHasOwnProperty;
- to.ObjectKeys = ObjectKeys;
});
%InstallToContext([
« no previous file with comments | « src/js/json.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698