Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1567863003: Rename SkGifCodec, SkIcoCodec, SkWbmpCodec (Closed)

Created:
4 years, 11 months ago by msarett
Modified:
4 years, 11 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1540 lines) Patch
M gyp/codec.gyp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/codec/SkCodec.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
D src/codec/SkCodec_libgif.h View 1 chunk +0 lines, -203 lines 0 comments Download
D src/codec/SkCodec_libgif.cpp View 1 chunk +0 lines, -590 lines 0 comments Download
D src/codec/SkCodec_libico.h View 1 chunk +0 lines, -87 lines 0 comments Download
D src/codec/SkCodec_libico.cpp View 1 chunk +0 lines, -378 lines 0 comments Download
D src/codec/SkCodec_wbmp.h View 1 chunk +0 lines, -63 lines 0 comments Download
D src/codec/SkCodec_wbmp.cpp View 1 chunk +0 lines, -212 lines 0 comments Download
A + src/codec/SkGifCodec.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/codec/SkGifCodec.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + src/codec/SkIcoCodec.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/codec/SkIcoCodec.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + src/codec/SkWbmpCodec.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/codec/SkWbmpCodec.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1188223002 Patch 60001

Messages

Total messages: 9 (5 generated)
msarett
Let me know if you have any active changes on these codecs, in which case ...
4 years, 11 months ago (2016-01-07 19:51:56 UTC) #4
scroggo
On 2016/01/07 19:51:56, msarett wrote: > Let me know if you have any active changes ...
4 years, 11 months ago (2016-01-07 20:44:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1567863003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1567863003/20001
4 years, 11 months ago (2016-01-07 20:59:51 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 21:17:21 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) as
https://skia.googlesource.com/skia/+/1a46467b6998f0ff7cb6912565de06510e937180

Powered by Google App Engine
This is Rietveld 408576698