Chromium Code Reviews| Index: content/browser/renderer_host/input/touch_event_queue_unittest.cc |
| diff --git a/content/browser/renderer_host/input/touch_event_queue_unittest.cc b/content/browser/renderer_host/input/touch_event_queue_unittest.cc |
| index fcd11f0aef5d4e14aa8a560757a2e309cd3126e2..30e37ba6ef36f1aa31064fb0f7d7bac5787190d8 100644 |
| --- a/content/browser/renderer_host/input/touch_event_queue_unittest.cc |
| +++ b/content/browser/renderer_host/input/touch_event_queue_unittest.cc |
| @@ -48,7 +48,7 @@ class TouchEventQueueTest : public testing::Test, |
| ++sent_event_count_; |
| last_sent_event_ = event.event; |
| if (sync_ack_result_) |
| - SendTouchEventACK(*sync_ack_result_.Pass()); |
| + SendTouchEventAck(*sync_ack_result_.Pass()); |
|
jdduke (slow)
2014/02/14 16:59:52
I always read the uppercase version as "ACK" being
|
| } |
| virtual void OnTouchEventAck( |
| @@ -92,10 +92,17 @@ class TouchEventQueueTest : public testing::Test, |
| GestureEventWithLatencyInfo(event, ui::LatencyInfo())); |
| } |
| - void SendTouchEventACK(InputEventAckState ack_result) { |
| + void SendTouchEventAck(InputEventAckState ack_result) { |
| queue_->ProcessTouchAck(ack_result, ui::LatencyInfo()); |
| } |
| + void SendGestureEventAck(WebInputEvent::Type type, |
| + InputEventAckState ack_result) { |
| + blink::WebGestureEvent gesture_event; |
| + gesture_event.type = type; |
| + GestureEventWithLatencyInfo event(gesture_event, ui::LatencyInfo()); |
| + } |
| + |
| void SetFollowupEvent(const WebTouchEvent& event) { |
| followup_touch_event_.reset(new WebTouchEvent(event)); |
| } |
| @@ -210,14 +217,14 @@ TEST_F(TouchEventQueueTest, Basic) { |
| EXPECT_EQ(0U, GetAndResetSentEventCount()); |
| // Receive an ACK for the first touch-event. |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_CONSUMED); |
| EXPECT_EQ(1U, queued_event_count()); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| EXPECT_EQ(1U, GetAndResetAckedEventCount()); |
| EXPECT_EQ(WebInputEvent::TouchStart, acked_event().type); |
| // Receive an ACK for the second touch-event. |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_CONSUMED); |
| EXPECT_EQ(0U, queued_event_count()); |
| EXPECT_EQ(0U, GetAndResetSentEventCount()); |
| EXPECT_EQ(1U, GetAndResetAckedEventCount()); |
| @@ -248,7 +255,7 @@ TEST_F(TouchEventQueueTest, QueueFlushedWhenHandlersRemoved) { |
| // Receive an ACK for the first touch-event. One of the queued touch-event |
| // should be forwarded. |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_CONSUMED); |
| EXPECT_EQ(31U, queued_event_count()); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| EXPECT_EQ(1U, GetAndResetAckedEventCount()); |
| @@ -309,7 +316,7 @@ TEST_F(TouchEventQueueTest, ActiveSequenceDroppedWhenHandlersRemoved) { |
| EXPECT_EQ(0U, queued_event_count()); |
| // The ack should be ignored as the touch queue is now empty. |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS); |
| EXPECT_EQ(0U, GetAndResetAckedEventCount()); |
| EXPECT_EQ(0U, queued_event_count()); |
| @@ -351,7 +358,7 @@ TEST_F(TouchEventQueueTest, Coalesce) { |
| EXPECT_EQ(3U, queued_event_count()); |
| // ACK the press. Coalesced touch-move events should be sent. |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_CONSUMED); |
| EXPECT_EQ(2U, queued_event_count()); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| EXPECT_EQ(1U, GetAndResetAckedEventCount()); |
| @@ -359,14 +366,14 @@ TEST_F(TouchEventQueueTest, Coalesce) { |
| EXPECT_EQ(INPUT_EVENT_ACK_STATE_CONSUMED, acked_event_state()); |
| // ACK the moves. |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_CONSUMED); |
| EXPECT_EQ(1U, queued_event_count()); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| EXPECT_EQ(10U, GetAndResetAckedEventCount()); |
| EXPECT_EQ(WebInputEvent::TouchMove, acked_event().type); |
| // ACK the release. |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_CONSUMED); |
| EXPECT_EQ(0U, queued_event_count()); |
| EXPECT_EQ(0U, GetAndResetSentEventCount()); |
| EXPECT_EQ(1U, GetAndResetAckedEventCount()); |
| @@ -388,7 +395,7 @@ TEST_F(TouchEventQueueTest, SentTouchEventDoesNotCoalesce) { |
| EXPECT_EQ(0U, GetAndResetSentEventCount()); |
| EXPECT_EQ(2U, queued_event_count()); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| EXPECT_EQ(1U, queued_event_count()); |
| @@ -450,7 +457,7 @@ TEST_F(TouchEventQueueTest, AckAfterQueueFlushed) { |
| // Receive an ACK for the press. This should cause the queued touch-move to |
| // be sent to the renderer. |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_CONSUMED); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| EXPECT_EQ(1U, queued_event_count()); |
| @@ -459,7 +466,7 @@ TEST_F(TouchEventQueueTest, AckAfterQueueFlushed) { |
| EXPECT_EQ(0U, queued_event_count()); |
| // Now receive an ACK for the move. |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_CONSUMED); |
| EXPECT_EQ(0U, GetAndResetSentEventCount()); |
| EXPECT_EQ(0U, queued_event_count()); |
| } |
| @@ -481,7 +488,7 @@ TEST_F(TouchEventQueueTest, NoConsumer) { |
| // Receive an ACK for the first touch-event. This should release the queued |
| // touch-event, but it should not be sent to the renderer. |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS); |
| EXPECT_EQ(0U, queued_event_count()); |
| EXPECT_EQ(WebInputEvent::TouchMove, acked_event().type); |
| EXPECT_EQ(2U, GetAndResetAckedEventCount()); |
| @@ -510,14 +517,14 @@ TEST_F(TouchEventQueueTest, NoConsumer) { |
| // touch-move event, the touch-end event and the second touch-press event. |
| EXPECT_EQ(4U, queued_event_count()); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| EXPECT_EQ(WebInputEvent::TouchEnd, acked_event().type); |
| EXPECT_EQ(4U, GetAndResetAckedEventCount()); |
| EXPECT_EQ(1U, queued_event_count()); |
| // ACK the second press event as NO_CONSUMER too. |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS); |
| EXPECT_EQ(0U, GetAndResetSentEventCount()); |
| EXPECT_EQ(WebInputEvent::TouchStart, acked_event().type); |
| EXPECT_EQ(1U, GetAndResetAckedEventCount()); |
| @@ -557,12 +564,12 @@ TEST_F(TouchEventQueueTest, ConsumerIgnoreMultiFinger) { |
| // ACK the first press as CONSUMED. This should cause the first touch-move of |
| // the first touch-point to be dispatched. |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_CONSUMED); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| EXPECT_EQ(3U, queued_event_count()); |
| // ACK the first move as CONSUMED. |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_CONSUMED); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| EXPECT_EQ(2U, queued_event_count()); |
| @@ -570,12 +577,12 @@ TEST_F(TouchEventQueueTest, ConsumerIgnoreMultiFinger) { |
| // touch-move event (which contains both touch points). Although the second |
| // touch-point does not need to be sent to the renderer, the first touch-point |
| // did move, and so the coalesced touch-event will be sent to the renderer. |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| EXPECT_EQ(1U, queued_event_count()); |
| // ACK the coalesced move as NOT_CONSUMED. |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| EXPECT_EQ(0U, GetAndResetSentEventCount()); |
| EXPECT_EQ(0U, queued_event_count()); |
| @@ -596,11 +603,11 @@ TEST_F(TouchEventQueueTest, ConsumerIgnoreMultiFinger) { |
| MoveTouchPoints(0, 15, 15, 1, 25, 25); |
| EXPECT_EQ(0U, GetAndResetSentEventCount()); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_CONSUMED); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| EXPECT_EQ(1U, queued_event_count()); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_CONSUMED); |
| EXPECT_EQ(0U, GetAndResetSentEventCount()); |
| EXPECT_EQ(0U, queued_event_count()); |
| @@ -622,14 +629,14 @@ TEST_F(TouchEventQueueTest, ConsumerIgnoreMultiFinger) { |
| EXPECT_EQ(0U, GetAndResetSentEventCount()); |
| EXPECT_EQ(4U, queued_event_count()); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| EXPECT_EQ(2U, queued_event_count()); |
| EXPECT_EQ(WebInputEvent::TouchMove, acked_event().type); |
| // ACK the press with NO_CONSUMED_EXISTS. This should release the queued |
| // touch-move events to the view. |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS); |
| EXPECT_EQ(0U, GetAndResetSentEventCount()); |
| EXPECT_EQ(0U, queued_event_count()); |
| EXPECT_EQ(WebInputEvent::TouchMove, acked_event().type); |
| @@ -659,7 +666,7 @@ TEST_F(TouchEventQueueTest, AckWithFollowupEvents) { |
| // Receive an ACK for the press. This should cause the followup touch-move to |
| // be sent to the renderer. |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_CONSUMED); |
| EXPECT_EQ(1U, queued_event_count()); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| EXPECT_EQ(1U, GetAndResetAckedEventCount()); |
| @@ -672,7 +679,7 @@ TEST_F(TouchEventQueueTest, AckWithFollowupEvents) { |
| // Receive an ACK for the touch-move followup event. This should cause the |
| // subsequent touch move event be sent to the renderer. |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_CONSUMED); |
| EXPECT_EQ(1U, queued_event_count()); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| EXPECT_EQ(1U, GetAndResetAckedEventCount()); |
| @@ -703,7 +710,7 @@ TEST_F(TouchEventQueueTest, SynchronousAcks) { |
| // TouchCancel (first inserting a TouchStart so the TouchCancel will be sent) |
| PressTouchPoint(1, 1); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_CONSUMED); |
| EXPECT_EQ(0U, queued_event_count()); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| EXPECT_EQ(1U, GetAndResetAckedEventCount()); |
| @@ -766,17 +773,17 @@ TEST_F(TouchEventQueueTest, NoTouchBasic) { |
| PressTouchPoint(80, 10); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| EXPECT_EQ(1U, GetAndResetAckedEventCount()); |
| MoveTouchPoint(0, 80, 20); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| EXPECT_EQ(1U, GetAndResetAckedEventCount()); |
| ReleaseTouchPoint(0); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| EXPECT_EQ(1U, GetAndResetAckedEventCount()); |
| } |
| @@ -785,7 +792,7 @@ TEST_F(TouchEventQueueTest, NoTouchOnScroll) { |
| // Queue a TouchStart. |
| PressTouchPoint(0, 1); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| EXPECT_EQ(1U, GetAndResetAckedEventCount()); |
| MoveTouchPoint(0, 20, 5); |
| @@ -802,7 +809,7 @@ TEST_F(TouchEventQueueTest, NoTouchOnScroll) { |
| WebGestureEvent followup_scroll; |
| followup_scroll.type = WebInputEvent::GestureScrollBegin; |
| SetFollowupEvent(followup_scroll); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| EXPECT_EQ(1U, GetAndResetAckedEventCount()); |
| EXPECT_EQ(2U, queued_event_count()); |
| @@ -810,7 +817,7 @@ TEST_F(TouchEventQueueTest, NoTouchOnScroll) { |
| EXPECT_EQ(WebInputEvent::TouchStart, latest_event().type); |
| // Acking the TouchCancel will result in dispatch of the next TouchStart. |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| // The synthetic TouchCancel should not reach client, only the TouchStart. |
| EXPECT_EQ(1U, GetAndResetAckedEventCount()); |
| EXPECT_EQ(0U, GetAndResetSentEventCount()); |
| @@ -839,17 +846,17 @@ TEST_F(TouchEventQueueTest, NoTouchOnScroll) { |
| // Touch events from a new gesture sequence should be forwarded normally. |
| PressTouchPoint(80, 10); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| EXPECT_EQ(1U, GetAndResetAckedEventCount()); |
| MoveTouchPoint(0, 80, 20); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| EXPECT_EQ(1U, GetAndResetAckedEventCount()); |
| ReleaseTouchPoint(0); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| EXPECT_EQ(1U, GetAndResetAckedEventCount()); |
| } |
| @@ -859,7 +866,7 @@ TEST_F(TouchEventQueueTest, NoTouchCancelOnScrollIfNoConsumer) { |
| // Queue a TouchStart. |
| PressTouchPoint(0, 1); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS); |
| EXPECT_EQ(1U, GetAndResetAckedEventCount()); |
| EXPECT_EQ(WebInputEvent::TouchStart, sent_event().type); |
| @@ -893,7 +900,7 @@ TEST_F(TouchEventQueueTest, NoTouchCancelOnScrollIfNoConsumer) { |
| // Touch events from a new gesture sequence should be forwarded normally. |
| PressTouchPoint(80, 10); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| EXPECT_EQ(1U, GetAndResetAckedEventCount()); |
| } |
| @@ -913,7 +920,7 @@ TEST_F(TouchEventQueueTest, PendingStart) { |
| EXPECT_TRUE(IsPendingAckTouchStart()); |
| // Ack the touchstart (#1). |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| EXPECT_EQ(1U, queued_event_count()); |
| EXPECT_FALSE(IsPendingAckTouchStart()); |
| @@ -923,7 +930,7 @@ TEST_F(TouchEventQueueTest, PendingStart) { |
| EXPECT_FALSE(IsPendingAckTouchStart()); |
| // Ack the touchmove (#2). |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| EXPECT_EQ(1U, queued_event_count()); |
| EXPECT_TRUE(IsPendingAckTouchStart()); |
| @@ -933,12 +940,12 @@ TEST_F(TouchEventQueueTest, PendingStart) { |
| EXPECT_TRUE(IsPendingAckTouchStart()); |
| // Ack the touchstart for the second point (#3). |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| EXPECT_EQ(1U, queued_event_count()); |
| EXPECT_TRUE(IsPendingAckTouchStart()); |
| // Ack the touchstart for the third point (#4). |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| EXPECT_EQ(0U, queued_event_count()); |
| EXPECT_FALSE(IsPendingAckTouchStart()); |
| } |
| @@ -950,28 +957,28 @@ TEST_F(TouchEventQueueTest, TouchTimeoutTypes) { |
| // Sending a TouchStart will start the timeout. |
| PressTouchPoint(0, 1); |
| EXPECT_TRUE(IsTimeoutRunning()); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| EXPECT_FALSE(IsTimeoutRunning()); |
| // A TouchMove should start the timeout. |
| MoveTouchPoint(0, 5, 5); |
| EXPECT_TRUE(IsTimeoutRunning()); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| EXPECT_FALSE(IsTimeoutRunning()); |
| // A TouchEnd should not start the timeout. |
| ReleaseTouchPoint(0); |
| EXPECT_FALSE(IsTimeoutRunning()); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| EXPECT_FALSE(IsTimeoutRunning()); |
| // A TouchCancel should not start the timeout. |
| PressTouchPoint(0, 1); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| ASSERT_FALSE(IsTimeoutRunning()); |
| CancelTouchPoint(0); |
| EXPECT_FALSE(IsTimeoutRunning()); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| EXPECT_FALSE(IsTimeoutRunning()); |
| } |
| @@ -1004,7 +1011,7 @@ TEST_F(TouchEventQueueTest, TouchTimeoutBasic) { |
| EXPECT_EQ(1U, GetAndResetAckedEventCount()); |
| // Ack'ing the original event should trigger a cancel event. |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| EXPECT_FALSE(IsTimeoutRunning()); |
| EXPECT_EQ(0U, GetAndResetAckedEventCount()); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| @@ -1020,7 +1027,7 @@ TEST_F(TouchEventQueueTest, TouchTimeoutBasic) { |
| // The synthetic TouchCancel ack should not reach the client, but should |
| // resume touch forwarding. |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| EXPECT_EQ(0U, GetAndResetSentEventCount()); |
| EXPECT_EQ(0U, GetAndResetAckedEventCount()); |
| @@ -1041,23 +1048,23 @@ TEST_F(TouchEventQueueTest, NoTouchTimeoutIfRendererIsConsumingGesture) { |
| // Mark the event as consumed. This should prevent the timeout from |
| // being activated on subsequent TouchEvents in this gesture. |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_CONSUMED); |
| EXPECT_FALSE(IsTimeoutRunning()); |
| // A TouchMove should not start the timeout. |
| MoveTouchPoint(0, 5, 5); |
| EXPECT_FALSE(IsTimeoutRunning()); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| // A secondary TouchStart should not start the timeout. |
| PressTouchPoint(1, 0); |
| EXPECT_FALSE(IsTimeoutRunning()); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| // A TouchEnd should not start the timeout. |
| ReleaseTouchPoint(1); |
| EXPECT_FALSE(IsTimeoutRunning()); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| // A TouchCancel should not start the timeout. |
| CancelTouchPoint(0); |
| @@ -1117,14 +1124,14 @@ TEST_F(TouchEventQueueTest, TouchTimeoutWithFollowupGesture) { |
| EXPECT_EQ(1U, GetAndResetAckedEventCount()); |
| // Ack the original event, triggering a TouchCancel. |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_CONSUMED); |
| EXPECT_FALSE(IsTimeoutRunning()); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| EXPECT_EQ(0U, GetAndResetAckedEventCount()); |
| // Ack the cancel event. Normally, this would resume touch forwarding, |
| // but we're still within a scroll gesture so it remains disabled. |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_CONSUMED); |
| EXPECT_FALSE(IsTimeoutRunning()); |
| EXPECT_EQ(0U, GetAndResetSentEventCount()); |
| EXPECT_EQ(0U, GetAndResetAckedEventCount()); |
| @@ -1193,12 +1200,12 @@ TEST_F(TouchEventQueueTest, TouchTimeoutWithFollowupGestureAndDelayedAck) { |
| EXPECT_EQ(2U, GetAndResetAckedEventCount()); |
| // Ack the original event, triggering a cancel. |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_CONSUMED); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| EXPECT_EQ(0U, GetAndResetAckedEventCount()); |
| // Ack the cancel event, resuming touch forwarding. |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_CONSUMED); |
| EXPECT_EQ(0U, GetAndResetSentEventCount()); |
| EXPECT_EQ(0U, GetAndResetAckedEventCount()); |
| @@ -1239,7 +1246,7 @@ TEST_F(TouchEventQueueTest, NoCancelOnTouchTimeoutWithoutConsumer) { |
| // Ack'ing the original event should not trigger a cancel event, as the |
| // TouchStart had no consumer. However, it should re-enable touch forwarding. |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS); |
| EXPECT_FALSE(IsTimeoutRunning()); |
| EXPECT_EQ(0U, GetAndResetAckedEventCount()); |
| EXPECT_EQ(0U, GetAndResetSentEventCount()); |
| @@ -1259,7 +1266,7 @@ TEST_F(TouchEventQueueTest, TouchMoveSuppressionWithinSlopRegion) { |
| // Queue a TouchStart. |
| PressTouchPoint(0, 0); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| ASSERT_EQ(1U, GetAndResetSentEventCount()); |
| ASSERT_EQ(1U, GetAndResetAckedEventCount()); |
| @@ -1293,7 +1300,7 @@ TEST_F(TouchEventQueueTest, TouchMoveSuppressionWithinSlopRegion) { |
| EXPECT_EQ(1U, queued_event_count()); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| EXPECT_EQ(0U, GetAndResetAckedEventCount()); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| EXPECT_EQ(1U, GetAndResetAckedEventCount()); |
| // Even TouchMove's within the original slop region should now be forwarded. |
| @@ -1301,14 +1308,14 @@ TEST_F(TouchEventQueueTest, TouchMoveSuppressionWithinSlopRegion) { |
| EXPECT_EQ(1U, queued_event_count()); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| EXPECT_EQ(0U, GetAndResetAckedEventCount()); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| EXPECT_EQ(1U, GetAndResetAckedEventCount()); |
| // A new touch sequence should reset suppression. |
| ReleaseTouchPoint(0); |
| PressTouchPoint(0, 0); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| ASSERT_EQ(2U, GetAndResetSentEventCount()); |
| ASSERT_EQ(2U, GetAndResetAckedEventCount()); |
| ASSERT_EQ(0U, queued_event_count()); |
| @@ -1334,7 +1341,7 @@ TEST_F(TouchEventQueueTest, NoTouchMoveSuppressionAfterTouchConsumed) { |
| // Queue a TouchStart. |
| PressTouchPoint(0, 1); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_CONSUMED); |
| ASSERT_EQ(1U, GetAndResetSentEventCount()); |
| ASSERT_EQ(1U, GetAndResetAckedEventCount()); |
| @@ -1356,7 +1363,7 @@ TEST_F(TouchEventQueueTest, NoTouchMoveSuppressionAfterMultiTouch) { |
| // Queue a TouchStart. |
| PressTouchPoint(0, 1); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| ASSERT_EQ(1U, GetAndResetSentEventCount()); |
| ASSERT_EQ(1U, GetAndResetAckedEventCount()); |
| @@ -1368,7 +1375,7 @@ TEST_F(TouchEventQueueTest, NoTouchMoveSuppressionAfterMultiTouch) { |
| // Simulate a secondary pointer press. |
| PressTouchPoint(kDoubleSlopLengthDips, 0); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| EXPECT_EQ(1U, GetAndResetAckedEventCount()); |
| @@ -1376,12 +1383,12 @@ TEST_F(TouchEventQueueTest, NoTouchMoveSuppressionAfterMultiTouch) { |
| MoveTouchPoint(1, kDoubleSlopLengthDips, 0); |
| EXPECT_EQ(1U, queued_event_count()); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| EXPECT_EQ(1U, GetAndResetAckedEventCount()); |
| // Release the secondary pointer. |
| ReleaseTouchPoint(0); |
| - SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| + SendTouchEventAck(INPUT_EVENT_ACK_STATE_NOT_CONSUMED); |
| EXPECT_EQ(1U, GetAndResetSentEventCount()); |
| EXPECT_EQ(1U, GetAndResetAckedEventCount()); |