Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1567733002: Fix type parameter element resolution for generics (Closed)

Created:
4 years, 11 months ago by Leaf
Modified:
4 years, 11 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix type parameter element resolution for generics BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/d11800e8f598964b93131bf8ba6de9d97f7c6076

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 1 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 2 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Leaf
4 years, 11 months ago (2016-01-06 21:58:29 UTC) #2
Jennifer Messerly
LGTM. I was just about to try and do this fix. \o/ https://codereview.chromium.org/1567733002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart File pkg/analyzer/lib/src/dart/element/element.dart ...
4 years, 11 months ago (2016-01-06 21:59:39 UTC) #3
Leaf
https://codereview.chromium.org/1567733002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart File pkg/analyzer/lib/src/dart/element/element.dart (right): https://codereview.chromium.org/1567733002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart#newcode2618 pkg/analyzer/lib/src/dart/element/element.dart:2618: * Set the type parameters defined by this type ...
4 years, 11 months ago (2016-01-06 22:15:41 UTC) #4
Leaf
4 years, 11 months ago (2016-01-06 22:15:59 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
d11800e8f598964b93131bf8ba6de9d97f7c6076 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698