Fix type parameter element resolution for generics

pkg/analyzer/test/generated/resolver_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.test.generated.resolver_test;
 
 import 'dart:collection';
 
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/type.dart';
@@ skipping 13003 matching lines @@
     check("f2", _isListOf(_isInt));
     check("f3", _isListOf(_isListOf(_isInt)));
   }
 }
 
 /**
  * Strong mode static analyzer end to end tests
  */
 @reflectiveTest
 class StrongModeStaticTypeAnalyzer2Test extends _StaticTypeAnalyzer2TestShared {
-  void fail_genericFunction_parameter() {
+  void test_genericFunction_parameter() {
     _resolveTestUnit(r'''
 void g(/*=T*/ f/*<T>*/(/*=T*/ x)) {}
 ''');
     SimpleIdentifier f = _findIdentifier('f');
     ParameterElementImpl e = f.staticElement;
+    FunctionType type = e.type;
     expect(e.typeParameters.toString(), '[T]');
-    expect(e.type.boundTypeParameters.toString(), '[T]');
-    expect(e.type.toString(), '<T>(T) → T');
-    FunctionType ft = e.type.instantiate([typeProvider.stringType]);
+    expect(type.boundTypeParameters.toString(), '[T]');
+    expect(type.toString(), '<T>(T) → T');
+    FunctionType ft = type.instantiate([typeProvider.stringType]);
     expect(ft.toString(), '(String) → String');
   }
 
   void fail_genericMethod_functionExpressionInvocation_explicit() {
     _resolveTestUnit(r'''
 class C<E> {
   /*=T*/ f/*<T>*/(/*=T*/ e) => null;
   static /*=T*/ g/*<T>*/(/*=T*/ e) => null;
   static final h = g;
 }
@@ skipping 107 matching lines @@
 ''');
     expect(_findIdentifier('methodCall').staticType.toString(), "int");
     expect(_findIdentifier('staticCall').staticType.toString(), "int");
     expect(_findIdentifier('staticFieldCall').staticType.toString(), "int");
     expect(_findIdentifier('topFunCall').staticType.toString(), "int");
     expect(_findIdentifier('topFieldCall').staticType.toString(), "int");
     expect(_findIdentifier('localCall').staticType.toString(), "int");
     expect(_findIdentifier('paramCall').staticType.toString(), "int");
   }
 
-  void fail_genericMethod_tearoff() {
+  void test_genericMethod_tearoff() {
     _resolveTestUnit(r'''
 class C<E> {
   /*=T*/ f/*<T>*/(E e) => null;
   static /*=T*/ g/*<T>*/(/*=T*/ e) => null;
   static final h = g;
 }
 
 /*=T*/ topF/*<T>*/(/*=T*/ e) => null;
 var topG = topF;
 void test/*<S>*/(/*=T*/ pf/*<T>*/(/*=T*/ e)) {
@@ skipping 3421 matching lines @@
 
   void _resolveTestUnit(String code) {
     testCode = code;
     testSource = addSource(testCode);
     LibraryElement library = resolve2(testSource);
     assertNoErrors(testSource);
     verify([testSource]);
     testUnit = resolveCompilationUnit(testSource, library);
   }
 }