Show cookies only for HTTP and HTTPS URLs.

Show cookies only for HTTP and HTTPS URLs.

Formerly, we would show cookies even if the hostname a file: URL matched a
domain for which there are cookies.

BUG=573317
Committed: https://crrev.com/a6acbbcaccdb4085f17d0eef1f266d48fa4baff0
Cr-Commit-Position: refs/heads/master@{#368676}

[palmer, 2016-01-07 20:58:18]

palmer@chromium.org changed reviewers:
+ felt@chromium.org, markusheintz@chromium.org

[Mike West, 2016-01-08 08:48:03]

On 2016/01/07 at 20:58:18, palmer wrote:
> 

This one LGTM too.

[felt, 2016-01-08 15:15:26]

This removes it for things besides file: URLs, right? All non-HTTP[S] URLs?

[markusheintz_, 2016-01-11 17:12:54]

On 2016/01/08 15:15:26, felt wrote:
> This removes it for things besides file: URLs, right? All non-HTTP[S] URLs?

Yes. If you change the description then this LGTM

[palmer, 2016-01-11 18:57:52]

Description was changed from

==========
Don't show cookies for file: URLs.

Even if the hostname in the file: URL matches a domain for which there are
cookies.

BUG=573317
==========

to

==========
Show cookies only for HTTP and HTTPS URLs.

Formerly, we would show cookies even if the hostname a file: URL matched a
domain for which there are cookies.

BUG=573317
==========

[palmer, 2016-01-11 19:01:43]

Description updated!

[palmer, 2016-01-11 19:01:46]

The CQ bit was checked by palmer@chromium.org

[palmer, 2016-01-11 19:01:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
markusheintz@chromium.org, mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/1567173002/#ps20001
(title: "Rebase and new description.")

[commit-bot: I haz the power, 2016-01-11 19:03:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1567173002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1567173002/20001

[commit-bot: I haz the power, 2016-01-11 19:52:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-11 19:52:09]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[palmer, 2016-01-11 20:38:47]

The CQ bit was checked by palmer@chromium.org

[palmer, 2016-01-11 20:38:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
markusheintz@chromium.org, mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/1567173002/#ps40001
(title: "Update test expectations.")

[commit-bot: I haz the power, 2016-01-11 20:39:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1567173002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1567173002/40001

[commit-bot: I haz the power, 2016-01-11 21:40:46]

Description was changed from

==========
Show cookies only for HTTP and HTTPS URLs.

Formerly, we would show cookies even if the hostname a file: URL matched a
domain for which there are cookies.

BUG=573317
==========

to

==========
Show cookies only for HTTP and HTTPS URLs.

Formerly, we would show cookies even if the hostname a file: URL matched a
domain for which there are cookies.

BUG=573317
==========

[commit-bot: I haz the power, 2016-01-11 21:40:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-11 21:42:17]

Description was changed from

==========
Show cookies only for HTTP and HTTPS URLs.

Formerly, we would show cookies even if the hostname a file: URL matched a
domain for which there are cookies.

BUG=573317
==========

to

==========
Show cookies only for HTTP and HTTPS URLs.

Formerly, we would show cookies even if the hostname a file: URL matched a
domain for which there are cookies.

BUG=573317

Committed: https://crrev.com/a6acbbcaccdb4085f17d0eef1f266d48fa4baff0
Cr-Commit-Position: refs/heads/master@{#368676}
==========

[commit-bot: I haz the power, 2016-01-11 21:42:18]

Patchset 3 (id:??) landed as
https://crrev.com/a6acbbcaccdb4085f17d0eef1f266d48fa4baff0
Cr-Commit-Position: refs/heads/master@{#368676}

[baranovich, 2016-03-25 14:07:00]

Seems like this change could brake persistent cookie display:

https://code.google.com/p/chromium/codesearch#chromium/src/net/extras/sqlite/...

Cookies from DB always have empty source