Blink side changes to toggle between the old and new GC visitor API.

Blink side changes to toggle between the old and new GC visitor API.

This gets rid of more places where Persistent handles are copied
(see bug).

The corresponding V8 side changes are in https://codereview.chromium.org/15974006 .

BUG=236290
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151732

[dcarney, 2013-05-28 12:59:07]

lgtm

[commit-bot: I haz the power, 2013-05-29 13:41:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/marja@chromium.org/15670010/1

[commit-bot: I haz the power, 2013-05-29 13:57:12]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_layout.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[marja, 2013-05-29 14:00:57]

oops, no, this shouldn't be committed before v8 rolls because the needed #define
is only in V8.

[commit-bot: I haz the power, 2013-06-03 07:53:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/marja@chromium.org/15670010/1

[commit-bot: I haz the power, 2013-06-03 09:31:58]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-06-04 08:01:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/marja@chromium.org/15670010/20001

[commit-bot: I haz the power, 2013-06-04 08:01:08]

Failed to apply patch for Source/bindings/v8/ScriptProfiler.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/v8/ScriptProfiler.cpp
  Hunk #1 FAILED at 279.
  Hunk #2 FAILED at 352.
  2 out of 2 hunks FAILED -- saving rejects to file
Source/bindings/v8/ScriptProfiler.cpp.rej

Patch:       Source/bindings/v8/ScriptProfiler.cpp
Index: Source/bindings/v8/ScriptProfiler.cpp
diff --git a/Source/bindings/v8/ScriptProfiler.cpp
b/Source/bindings/v8/ScriptProfiler.cpp
index
58e9e788ff83a53e113282cb6456f0857d074b3b..12c6374c1c10671cbdbbf1a4214fda12175016d2
100644
--- a/Source/bindings/v8/ScriptProfiler.cpp
+++ b/Source/bindings/v8/ScriptProfiler.cpp
@@ -279,14 +279,23 @@ void ScriptProfiler::visitNodeWrappers(WrappedNodeVisitor*
visitor)
         {
         }
 
+
+#ifdef V8_USE_OLD_STYLE_PERSISTENT_HANDLE_VISITORS
         virtual void VisitPersistentHandle(v8::Persistent<v8::Value> value,
uint16_t classId) OVERRIDE
         {
+            VisitPersistentHandle(&value, classId);
+        }
+
+        virtual void VisitPersistentHandle(v8::Persistent<v8::Value>* value,
uint16_t classId)
+#else
+        virtual void VisitPersistentHandle(v8::Persistent<v8::Value>* value,
uint16_t classId) OVERRIDE
+#endif
+        {
             if (classId != v8DOMNodeClassId)
                 return;
-            UNUSED_PARAM(m_isolate);
-            ASSERT(V8Node::HasInstance(value, m_isolate,
worldType(m_isolate)));
-            ASSERT(value->IsObject());
-            v8::Persistent<v8::Object> wrapper =
v8::Persistent<v8::Object>::Cast(value);
+            ASSERT(V8Node::HasInstance(*value, m_isolate,
worldType(m_isolate)));
+            ASSERT((*value)->IsObject());
+            v8::Persistent<v8::Object> wrapper =
v8::Persistent<v8::Object>::Cast(*value);
             m_visitor->visitNode(V8Node::toNative(wrapper));
         }
 
@@ -352,4 +361,3 @@ ProfileNameIdleTimeMap*
ScriptProfiler::currentProfileNameIdleTimeMap()
 }
 
 } // namespace WebCore
-

[commit-bot: I haz the power, 2013-06-04 08:58:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/marja@chromium.org/15670010/27001

[commit-bot: I haz the power, 2013-06-04 10:23:41]

Change committed as 151732