Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 15974006: Transforming PersistentHandleVisitor to not need to copy Persistent handles. (Closed)

Created:
7 years, 6 months ago by marja
Modified:
7 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Transforming PersistentHandleVisitor to not need to copy Persistent handles. This gets rid of more places where Persistent handles are copied (see crbug.com/236290 ). Transition plan: after this CL, Blink will be modified to work both with and without the #define, then the #define will be removed from V8. The corresponding Blink side changes are in https://codereview.chromium.org/15670010/ . BUG= R=dcarney@chromium.org, svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14871

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M include/v8.h View 2 chunks +6 lines, -0 lines 0 comments Download
M src/api.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dcarney
lgtm https://codereview.chromium.org/15974006/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/15974006/diff/1/src/api.cc#newcode5111 src/api.cc:5111: Persistent<Value> handle = ToApi<Value>(i::Handle<i::Object>(p)); can you make this ...
7 years, 6 months ago (2013-05-28 12:58:11 UTC) #1
dcarney
lgtm
7 years, 6 months ago (2013-05-28 12:58:11 UTC) #2
marja
svenpanne, ptal
7 years, 6 months ago (2013-05-28 14:06:32 UTC) #3
marja
(comment done) https://codereview.chromium.org/15974006/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/15974006/diff/1/src/api.cc#newcode5111 src/api.cc:5111: Persistent<Value> handle = ToApi<Value>(i::Handle<i::Object>(p)); On 2013/05/28 12:58:11, ...
7 years, 6 months ago (2013-05-28 14:07:18 UTC) #4
Sven Panne
lgtm
7 years, 6 months ago (2013-05-29 07:34:37 UTC) #5
dcarney
7 years, 6 months ago (2013-05-29 08:48:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r14871 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698