Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1566973002: [date] Date parser says true even for wrong dates, check twice. (Closed)

Created:
4 years, 11 months ago by Benedikt Meurer
Modified:
4 years, 11 months ago
Reviewers:
Jarin, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[date] Date parser says true even for wrong dates, check twice. R=yangguo@chromium.org BUG=chromium:575082 LOG=n Committed: https://crrev.com/b0d0d57d2b43cb3af2b0b41e0a3457d1e8ef2b1c Cr-Commit-Position: refs/heads/master@{#33149}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/builtins.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/date.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-575082.js View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Benedikt Meurer
4 years, 11 months ago (2016-01-07 08:38:29 UTC) #1
Jarin
lgtm
4 years, 11 months ago (2016-01-07 09:26:26 UTC) #3
Yang
lgtm
4 years, 11 months ago (2016-01-07 09:26:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566973002/1
4 years, 11 months ago (2016-01-07 09:26:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-07 09:30:43 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 09:30:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0d0d57d2b43cb3af2b0b41e0a3457d1e8ef2b1c
Cr-Commit-Position: refs/heads/master@{#33149}

Powered by Google App Engine
This is Rietveld 408576698