src/date.cc - Issue 1566973002: [date] Date parser says true even for wrong dates, check twice.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/date.cc

Issue 1566973002: [date] Date parser says true even for wrong dates, check twice. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/date.cc

diff --git a/src/date.cc b/src/date.cc

index 8cbf5a602ae1ea888939e6ade8b6228cdb855e37..f98ad64f1f871cb7155600b3a25d286aed1ccaf2 100644

--- a/src/date.cc

+++ b/src/date.cc

@@ -71,7 +71,7 @@ void DateCache::YearMonthDayFromDays(

*year = 400 * (days / kDaysIn400Years) - kYearsOffset;

days %= kDaysIn400Years;

- DCHECK(DaysFromYearMonth(*year, 0) + days == save_days);

+ DCHECK_EQ(save_days, DaysFromYearMonth(*year, 0) + days);

days--;

int yd1 = days / kDaysIn100Years;

« no previous file with comments | « src/builtins.cc ('k') | test/mjsunit/regress/regress-crbug-575082.js » ('j') | no next file with comments »