Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 156653004: Revert of Either content elements or shadow elements should not be treated as insertion points if they are no… (Closed)

Created:
6 years, 10 months ago by hayato
Modified:
6 years, 10 months ago
Reviewers:
Hajime Morrita, esprehn, dglazkov
CC:
blink-reviews, arv+blink, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Revert of Either content elements or shadow elements should not be treated as insertion points if they are no… (https://codereview.chromium.org/133213008/) Reason for revert: This patch might cause inconsistency between Polyfill and native Shadow DOM. It might be better to revert this patch until we have clear consensus for this change. Original issue's description: > Either content elements or shadow elements should not be treated as insertion points if they are not in document. > > The relevant spec update: https://github.com/w3c/webcomponents/commit/69fbceabe01786ba3740728a6b86f5ec958f69b4 > > This behavior is similar to that of styles, which are not calculated for disconnected nodes. > > This change also makes it possible to add an assertion, ASSERT(shadowRoot), for rootNode of an insertionPoint in InsertionPoint::isActive. > > BUG=339029 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166647 TBR=esprehn@google.com,dglazkov@chromium.org,morrita@chromium.org NOTREECHECKS=true NOTRY=true BUG=339029 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166802

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -5 lines) Patch
M LayoutTests/fast/dom/shadow/get-distributed-nodes-orphan.html View 2 chunks +25 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/get-distributed-nodes-orphan-expected.txt View 1 chunk +19 lines, -1 line 0 comments Download
M Source/core/dom/shadow/InsertionPoint.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
hayato
Created Revert of Either content elements or shadow elements should not be treated as insertion ...
6 years, 10 months ago (2014-02-10 05:20:14 UTC) #1
esprehn_google.com
6 years, 10 months ago (2014-02-10 05:35:45 UTC) #2
Lgtm

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698