Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 15665004: DevTools: [CodeMirror] add comment plugin (Closed)

Created:
7 years, 6 months ago by lushnikov
Modified:
7 years, 6 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: [CodeMirror] add comment plugin Add comment.js plugin and bind it to Ctrl(Cmd)+/ key combination. BUG=167284 R=vsevik@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151392

Patch Set 1 #

Patch Set 2 : add shortcut #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -3 lines) Patch
M Source/devtools/devtools.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/CodeMirrorTextEditor.js View 2 chunks +4 lines, -1 line 0 comments Download
M Source/devtools/front_end/ScriptsPanelDescriptor.js View 1 3 chunks +7 lines, -2 lines 0 comments Download
A Source/devtools/front_end/cm/comment.js View 1 chunk +144 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
lushnikov
Please take a look
7 years, 6 months ago (2013-05-28 13:02:17 UTC) #1
vsevik
lgtm
7 years, 6 months ago (2013-05-29 10:12:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/15665004/2001
7 years, 6 months ago (2013-05-29 10:12:30 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=10685
7 years, 6 months ago (2013-05-29 11:02:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/15665004/2001
7 years, 6 months ago (2013-05-29 12:06:05 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=7405
7 years, 6 months ago (2013-05-29 14:49:44 UTC) #6
lushnikov
7 years, 6 months ago (2013-05-29 15:59:10 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r151392 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698