Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1566463002: Generate located Windows keycodes for number pad keys under Ozone (Closed)

Created:
4 years, 11 months ago by kpschoedel
Modified:
4 years, 9 months ago
Reviewers:
dtapuska
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate located Windows keycodes for number pad keys under Ozone Makes Ozone's XKB keyboard layout support generate Windows keycodes VKEY_NUMPAD0 through VKEY_NUMPAD9 for number pad keys, rather than VKEY_0 through VKEY_9, to match the X11 behaviour. BUG=574458 Committed: https://crrev.com/631eb39240d4f2f2bb9c764f1adc225e844791d5 Cr-Commit-Position: refs/heads/master@{#381709}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc View 3 chunks +10 lines, -5 lines 0 comments Download
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine_unittest.cc View 3 chunks +5 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (7 generated)
dtapuska
lgtm
4 years, 11 months ago (2016-01-08 01:10:23 UTC) #3
dtapuska
On 2016/01/08 01:10:23, dtapuska wrote: > lgtm are you going to land this?
4 years, 9 months ago (2016-03-17 14:15:56 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566463002/1
4 years, 9 months ago (2016-03-17 14:21:25 UTC) #6
kpschoedel
On 2016/03/17 14:15:56, dtapuska wrote: > are you going to land this? Sorry, forgot it ...
4 years, 9 months ago (2016-03-17 14:22:24 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-17 14:53:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566463002/1
4 years, 9 months ago (2016-03-17 14:55:45 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 15:00:46 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 15:02:22 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/631eb39240d4f2f2bb9c764f1adc225e844791d5
Cr-Commit-Position: refs/heads/master@{#381709}

Powered by Google App Engine
This is Rietveld 408576698