Rename KEY_ constants to avoid conflict with <linux/input.h>

Rename KEY_ constants to avoid conflict with <linux/input.h>

Most |enum class DomCode| constants are named by mapping the names from
the W3C specification from CamelCase to SHOUTY_CASE. For the Latin
letters, named 'KeyX' in the spec, the KEY_X form conflicts with macro
definitions in <linux/input.h>. This change renames DomCode::KEY_X
constants to DomCode::US_X to avoid the conflict and to highlight
that these are positional codes corresponding to the labels
on a US QWERTY layout.

(TBR for 15 files with only spelling changes.)

R=wez@chromium.org
TBR=ben@chromium.org

Committed: https://crrev.com/a281bf14844158a68c774a02b960e3c3144b8bd0
Cr-Commit-Position: refs/heads/master@{#368075}

[kpschoedel, 2016-01-05 23:27:04]

The CQ bit was checked by kpschoedel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-05 23:27:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1560293002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1560293002/1

[commit-bot: I haz the power, 2016-01-06 00:38:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-06 00:38:31]

Dry run: This issue passed the CQ dry run.

[kpschoedel, 2016-01-06 16:36:54]

Description was changed from

==========
Rename KEY_ constants to avoid conflict with <linux/input.h>

Most |enum class DomCode| constants are named by mapping the names from
the W3C specification from CamelCase to SHOUTY_CASE. For the Latin
letters, named 'KeyX' in the spec, the KEY_X form conflicts with macro
definitions in <linux/input.h>.
==========

to

==========
Rename KEY_ constants to avoid conflict with <linux/input.h>

Most |enum class DomCode| constants are named by mapping the names from
the W3C specification from CamelCase to SHOUTY_CASE. For the Latin
letters, named 'KeyX' in the spec, the KEY_X form conflicts with macro
definitions in <linux/input.h>.
==========

[kpschoedel, 2016-01-06 16:36:55]

kpschoedel@chromium.org changed reviewers:
+ wez@chromium.org

[kpschoedel, 2016-01-06 16:36:55]

kpschoedel@chromium.org changed required reviewers:
+ wez@chromium.org

[kpschoedel, 2016-01-06 16:42:10]

+Wez@ for keycode_converter_data.inc in line with discussion on
https://codereview.chromium.org/1165223003 and reminded by
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/bbkV7DvWs5Q/cH3CF...

+cc dcheng@ fyi

[Wez, 2016-01-06 21:52:49]

LGTM

I'm not keen on the DomCode::X form - DOM uses the KeyX form to make it clearer
that it's a convenient way to refer to "the key that has X on it under a US
English layout". How would you feel about DomCode::US_X or something of that
form?

P.S. This CL would be easier to review without all the git cl format changes in
it!

[kpschoedel, 2016-01-06 22:27:56]

On 2016/01/06 21:52:49, Wez wrote:
> I'm not keen on the DomCode::X form - DOM uses the KeyX form to make it
clearer
> that it's a convenient way to refer to "the key that has X on it under a US
> English layout". How would you feel about DomCode::US_X or something of that
> form?

Done.

> P.S. This CL would be easier to review without all the git cl format changes
in
> it!

Yeah; --bypass-hooks to the rescue.

[kpschoedel, 2016-01-06 22:28:05]

The CQ bit was checked by kpschoedel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-06 22:29:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1560293002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1560293002/20001

[commit-bot: I haz the power, 2016-01-07 00:44:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-07 00:44:01]

Dry run: This issue passed the CQ dry run.

[kpschoedel, 2016-01-07 15:02:45]

Description was changed from

==========
Rename KEY_ constants to avoid conflict with <linux/input.h>

Most |enum class DomCode| constants are named by mapping the names from
the W3C specification from CamelCase to SHOUTY_CASE. For the Latin
letters, named 'KeyX' in the spec, the KEY_X form conflicts with macro
definitions in <linux/input.h>.
==========

to

==========
Rename KEY_ constants to avoid conflict with <linux/input.h>

Most |enum class DomCode| constants are named by mapping the names from
the W3C specification from CamelCase to SHOUTY_CASE. For the Latin
letters, named 'KeyX' in the spec, the KEY_X form conflicts with macro
definitions in <linux/input.h>. This change renames DomCode::KEY_X
constants to DomCode::US_X to avoid the conflict and to highlight
that these are positional codes corresponding to the labels
on a US QWERTY layout.

(TBR for 15 files with only spelling changes.)

R=wez@chromium.org
TBR=ben@chromium.org
==========

[kpschoedel, 2016-01-07 15:02:57]

The CQ bit was checked by kpschoedel@chromium.org

[kpschoedel, 2016-01-07 15:02:57]

The patchset sent to the CQ was uploaded after l-g-t-m from wez@chromium.org
Link to the patchset: https://codereview.chromium.org/1560293002/#ps20001
(title: "Address review comments (Wez)")

[commit-bot: I haz the power, 2016-01-07 15:03:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1560293002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1560293002/20001

[commit-bot: I haz the power, 2016-01-07 15:08:29]

Description was changed from

==========
Rename KEY_ constants to avoid conflict with <linux/input.h>

Most |enum class DomCode| constants are named by mapping the names from
the W3C specification from CamelCase to SHOUTY_CASE. For the Latin
letters, named 'KeyX' in the spec, the KEY_X form conflicts with macro
definitions in <linux/input.h>. This change renames DomCode::KEY_X
constants to DomCode::US_X to avoid the conflict and to highlight
that these are positional codes corresponding to the labels
on a US QWERTY layout.

(TBR for 15 files with only spelling changes.)

R=wez@chromium.org
TBR=ben@chromium.org
==========

to

==========
Rename KEY_ constants to avoid conflict with <linux/input.h>

Most |enum class DomCode| constants are named by mapping the names from
the W3C specification from CamelCase to SHOUTY_CASE. For the Latin
letters, named 'KeyX' in the spec, the KEY_X form conflicts with macro
definitions in <linux/input.h>. This change renames DomCode::KEY_X
constants to DomCode::US_X to avoid the conflict and to highlight
that these are positional codes corresponding to the labels
on a US QWERTY layout.

(TBR for 15 files with only spelling changes.)

R=wez@chromium.org
TBR=ben@chromium.org
==========

[commit-bot: I haz the power, 2016-01-07 15:08:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-07 15:09:29]

Description was changed from

==========
Rename KEY_ constants to avoid conflict with <linux/input.h>

Most |enum class DomCode| constants are named by mapping the names from
the W3C specification from CamelCase to SHOUTY_CASE. For the Latin
letters, named 'KeyX' in the spec, the KEY_X form conflicts with macro
definitions in <linux/input.h>. This change renames DomCode::KEY_X
constants to DomCode::US_X to avoid the conflict and to highlight
that these are positional codes corresponding to the labels
on a US QWERTY layout.

(TBR for 15 files with only spelling changes.)

R=wez@chromium.org
TBR=ben@chromium.org
==========

to

==========
Rename KEY_ constants to avoid conflict with <linux/input.h>

Most |enum class DomCode| constants are named by mapping the names from
the W3C specification from CamelCase to SHOUTY_CASE. For the Latin
letters, named 'KeyX' in the spec, the KEY_X form conflicts with macro
definitions in <linux/input.h>. This change renames DomCode::KEY_X
constants to DomCode::US_X to avoid the conflict and to highlight
that these are positional codes corresponding to the labels
on a US QWERTY layout.

(TBR for 15 files with only spelling changes.)

R=wez@chromium.org
TBR=ben@chromium.org

Committed: https://crrev.com/a281bf14844158a68c774a02b960e3c3144b8bd0
Cr-Commit-Position: refs/heads/master@{#368075}
==========

[commit-bot: I haz the power, 2016-01-07 15:09:30]

Patchset 2 (id:??) landed as
https://crrev.com/a281bf14844158a68c774a02b960e3c3144b8bd0
Cr-Commit-Position: refs/heads/master@{#368075}