Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1566443002: Revert of Change HistoryInfoMap to use unordered_map. (Closed)

Created:
4 years, 11 months ago by Georges Khalil
Modified:
4 years, 11 months ago
Reviewers:
Peter Kasting, Mark P
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change HistoryInfoMap to use unordered_map. (patchset #2 id:20001 of https://codereview.chromium.org/1482443002/ ) Reason for revert: This introduced a clear regression in the omnibox performance. See bug 574181. Original issue's description: > Change HistoryInfoMap to use unordered_map. > > This change speeds up the omnibox by 5-10% in my (limited) tests, using a large profile and checking the value of the Omnibox.CharTypedToRepaintLatency histogram. > > This was also validated when profiling, where the find method was the top function where CPU cycles were consumed. After switching to a hash map, it was a non factor. > > Note: As far as I can tell, the order is not important, so this change doesn't alter expected behavior. > > BUG=574181 > > Committed: https://crrev.com/6ddf83a44cb65d2540e8b78c4ff56d240a1d0597 > Cr-Commit-Position: refs/heads/master@{#362532} TBR=pkasting@chromium.org,mpearson@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=574181 Committed: https://crrev.com/554207590d8fb848bd21997a23093efc35ce1dd9 Cr-Commit-Position: refs/heads/master@{#367625}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M components/omnibox/browser/in_memory_url_index_types.h View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Georges Khalil
Created Revert of Change HistoryInfoMap to use unordered_map.
4 years, 11 months ago (2016-01-05 20:09:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566443002/1
4 years, 11 months ago (2016-01-05 20:10:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-05 20:12:47 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/554207590d8fb848bd21997a23093efc35ce1dd9 Cr-Commit-Position: refs/heads/master@{#367625}
4 years, 11 months ago (2016-01-05 20:13:40 UTC) #6
Peter Kasting
4 years, 11 months ago (2016-01-05 20:19:45 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698