Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1566423002:
Avoid LSan false positives from CSSPathValue::emptyValue(). (Closed)
|
Created:
4 years, 11 months ago by sof Modified:
4 years, 11 months ago CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAvoid LSan false positives from CSSPathValue::emptyValue().
LSan reports a leak on SVGComputedStyleTest.MiscStyleShouldCompareValue
(with Oilpan), stemming from emptyValue()'s allocation of an
SVGPathByteStream object. Introduce a local constructor function that
explicitly keeps this sub-object from LSan's view -- it is owned by
the emptyValue singleton and shouldn't be considered a leak.
R=haraken
BUG=
Committed: https://crrev.com/08494b981bbe6e9925ffd6663e65b6151bdd9425
Cr-Commit-Position: refs/heads/master@{#368329}
Committed: https://crrev.com/25b2a54f62c44915daf16184699640f4ef467a70
Cr-Commit-Position: refs/heads/master@{#368346}
Patch Set 1 #Patch Set 2 : Rebase and adjust to RefPtr<> #Messages
Total messages: 24 (12 generated)
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566423002/1
sigbjornf@opera.com changed reviewers: + oilpan-reviews@chromium.org
please take a look. With https://codereview.chromium.org/1564323002/ in scope, the one remaining LSan leak on webkit_unit_tests (Oilpan.)
LGTM
Description was changed from ========== Avoid LSan false positives from CSSPathValue::emptyValue(). LSan reports a leak on SVGComputedStyleTest.MiscStyleShouldCompareValue (with Oilpan), stemming from emptyValue()'s allocation of an SVGPathByteStream object. Introduce a local constructor function that explicitly keeps this sub-object from LSan's view -- it is owned by the emptyValue singleton and shouldn't be considered a leak. R= BUG= ========== to ========== Avoid LSan false positives from CSSPathValue::emptyValue(). LSan reports a leak on SVGComputedStyleTest.MiscStyleShouldCompareValue (with Oilpan), stemming from emptyValue()'s allocation of an SVGPathByteStream object. Introduce a local constructor function that explicitly keeps this sub-object from LSan's view -- it is owned by the emptyValue singleton and shouldn't be considered a leak. R=haraken BUG= ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566423002/1
Message was sent while issue was closed.
Description was changed from ========== Avoid LSan false positives from CSSPathValue::emptyValue(). LSan reports a leak on SVGComputedStyleTest.MiscStyleShouldCompareValue (with Oilpan), stemming from emptyValue()'s allocation of an SVGPathByteStream object. Introduce a local constructor function that explicitly keeps this sub-object from LSan's view -- it is owned by the emptyValue singleton and shouldn't be considered a leak. R=haraken BUG= ========== to ========== Avoid LSan false positives from CSSPathValue::emptyValue(). LSan reports a leak on SVGComputedStyleTest.MiscStyleShouldCompareValue (with Oilpan), stemming from emptyValue()'s allocation of an SVGPathByteStream object. Introduce a local constructor function that explicitly keeps this sub-object from LSan's view -- it is owned by the emptyValue singleton and shouldn't be considered a leak. R=haraken BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Avoid LSan false positives from CSSPathValue::emptyValue(). LSan reports a leak on SVGComputedStyleTest.MiscStyleShouldCompareValue (with Oilpan), stemming from emptyValue()'s allocation of an SVGPathByteStream object. Introduce a local constructor function that explicitly keeps this sub-object from LSan's view -- it is owned by the emptyValue singleton and shouldn't be considered a leak. R=haraken BUG= ========== to ========== Avoid LSan false positives from CSSPathValue::emptyValue(). LSan reports a leak on SVGComputedStyleTest.MiscStyleShouldCompareValue (with Oilpan), stemming from emptyValue()'s allocation of an SVGPathByteStream object. Introduce a local constructor function that explicitly keeps this sub-object from LSan's view -- it is owned by the emptyValue singleton and shouldn't be considered a leak. R=haraken BUG= Committed: https://crrev.com/08494b981bbe6e9925ffd6663e65b6151bdd9425 Cr-Commit-Position: refs/heads/master@{#368329} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/08494b981bbe6e9925ffd6663e65b6151bdd9425 Cr-Commit-Position: refs/heads/master@{#368329}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1570513005/ by treib@chromium.org. The reason for reverting is: Broke Cast Android (dbg) build: https://build.chromium.org/p/chromium.linux/builders/Cast%20Android%20(dbg).
Message was sent while issue was closed.
Description was changed from ========== Avoid LSan false positives from CSSPathValue::emptyValue(). LSan reports a leak on SVGComputedStyleTest.MiscStyleShouldCompareValue (with Oilpan), stemming from emptyValue()'s allocation of an SVGPathByteStream object. Introduce a local constructor function that explicitly keeps this sub-object from LSan's view -- it is owned by the emptyValue singleton and shouldn't be considered a leak. R=haraken BUG= Committed: https://crrev.com/08494b981bbe6e9925ffd6663e65b6151bdd9425 Cr-Commit-Position: refs/heads/master@{#368329} ========== to ========== Avoid LSan false positives from CSSPathValue::emptyValue(). LSan reports a leak on SVGComputedStyleTest.MiscStyleShouldCompareValue (with Oilpan), stemming from emptyValue()'s allocation of an SVGPathByteStream object. Introduce a local constructor function that explicitly keeps this sub-object from LSan's view -- it is owned by the emptyValue singleton and shouldn't be considered a leak. R=haraken BUG= Committed: https://crrev.com/08494b981bbe6e9925ffd6663e65b6151bdd9425 Cr-Commit-Position: refs/heads/master@{#368329} ==========
rebased; relanding.
The CQ bit was checked by sigbjornf@opera.com
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org Link to the patchset: https://codereview.chromium.org/1566423002/#ps20001 (title: "Rebase and adjust to RefPtr<>")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566423002/20001
Message was sent while issue was closed.
Description was changed from ========== Avoid LSan false positives from CSSPathValue::emptyValue(). LSan reports a leak on SVGComputedStyleTest.MiscStyleShouldCompareValue (with Oilpan), stemming from emptyValue()'s allocation of an SVGPathByteStream object. Introduce a local constructor function that explicitly keeps this sub-object from LSan's view -- it is owned by the emptyValue singleton and shouldn't be considered a leak. R=haraken BUG= Committed: https://crrev.com/08494b981bbe6e9925ffd6663e65b6151bdd9425 Cr-Commit-Position: refs/heads/master@{#368329} ========== to ========== Avoid LSan false positives from CSSPathValue::emptyValue(). LSan reports a leak on SVGComputedStyleTest.MiscStyleShouldCompareValue (with Oilpan), stemming from emptyValue()'s allocation of an SVGPathByteStream object. Introduce a local constructor function that explicitly keeps this sub-object from LSan's view -- it is owned by the emptyValue singleton and shouldn't be considered a leak. R=haraken BUG= Committed: https://crrev.com/08494b981bbe6e9925ffd6663e65b6151bdd9425 Cr-Commit-Position: refs/heads/master@{#368329} ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Avoid LSan false positives from CSSPathValue::emptyValue(). LSan reports a leak on SVGComputedStyleTest.MiscStyleShouldCompareValue (with Oilpan), stemming from emptyValue()'s allocation of an SVGPathByteStream object. Introduce a local constructor function that explicitly keeps this sub-object from LSan's view -- it is owned by the emptyValue singleton and shouldn't be considered a leak. R=haraken BUG= Committed: https://crrev.com/08494b981bbe6e9925ffd6663e65b6151bdd9425 Cr-Commit-Position: refs/heads/master@{#368329} ========== to ========== Avoid LSan false positives from CSSPathValue::emptyValue(). LSan reports a leak on SVGComputedStyleTest.MiscStyleShouldCompareValue (with Oilpan), stemming from emptyValue()'s allocation of an SVGPathByteStream object. Introduce a local constructor function that explicitly keeps this sub-object from LSan's view -- it is owned by the emptyValue singleton and shouldn't be considered a leak. R=haraken BUG= Committed: https://crrev.com/08494b981bbe6e9925ffd6663e65b6151bdd9425 Cr-Commit-Position: refs/heads/master@{#368329} Committed: https://crrev.com/25b2a54f62c44915daf16184699640f4ef467a70 Cr-Commit-Position: refs/heads/master@{#368346} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/25b2a54f62c44915daf16184699640f4ef467a70 Cr-Commit-Position: refs/heads/master@{#368346} |
