Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1566393002: Fix condition error from crrev.com/1562083002 (Closed)

Created:
4 years, 11 months ago by ssid
Modified:
4 years, 11 months ago
Reviewers:
ssid1, petrcermak
CC:
chromium-reviews, alex clarke (OOO till 29th)
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_cr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix condition error from crrev.com/1562083002 Committed: https://crrev.com/2bff3b28cd5b91683f3f38d0d0161d16ea1b1f63 Cr-Commit-Position: refs/heads/master@{#368311}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/cr/cr/commands/init.py View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1562083002 Patch 60001

Messages

Total messages: 12 (5 generated)
ssid
Sorry, I missed a not in previous CL.
4 years, 11 months ago (2016-01-08 11:20:29 UTC) #2
petrcermak
LGTM. Thanks for the quick fix. Petr
4 years, 11 months ago (2016-01-08 11:21:21 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566393002/1
4 years, 11 months ago (2016-01-08 11:21:33 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-08 11:37:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566393002/1
4 years, 11 months ago (2016-01-08 11:38:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 11:42:45 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 11:43:50 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2bff3b28cd5b91683f3f38d0d0161d16ea1b1f63
Cr-Commit-Position: refs/heads/master@{#368311}

Powered by Google App Engine
This is Rietveld 408576698