tools/cr/cr/commands/init.py - Issue 1566393002: Fix condition error from crrev.com/1562083002

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/cr/cr/commands/init.py

Issue 1566393002: Fix condition error from crrev.com/1562083002 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix_cr

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/cr/cr/commands/init.py

diff --git a/tools/cr/cr/commands/init.py b/tools/cr/cr/commands/init.py

index 7b09330cbf8c81c91c59d52cfe4340a33705de81..04692bae6cbff91728918c4e7f0677cd75288f27 100644

--- a/tools/cr/cr/commands/init.py

+++ b/tools/cr/cr/commands/init.py

@@ -87,7 +87,7 @@ class InitCommand(cr.Command):

# substrings. This is done to support "linuxchromeos" and "linux".

platform = max(matches, key=len)

all_matches_are_substrings = all(p in platform for p in matches)

- if all_matches_are_substrings or not matches:

+ if not all_matches_are_substrings or not matches:

print 'Platform is not set, and could not be guessed from', base

print 'Should be one of', ','.join(platforms)

if len(matches) > 1:

« no previous file with comments | « no previous file | no next file » | no next file with comments »