Chromium Code Reviews

Issue 1566173003: Mark Object.observe as deprecated (Closed)

Created:
4 years, 11 months ago by adamk
Modified:
4 years, 11 months ago
Reviewers:
jochen (gone - plz use gerrit)
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark Object.observe as deprecated Optimistically targetting M50 at the moment. Note that V8 only calls out to Blink once per Object.observe call per realm, but that seems to already match Blink's deprecation message behavior so I don't believe any changes are required on the V8 side. R=jochen@chromium.org BUG=552100 Committed: https://crrev.com/47a491d0b3f398b24aaef13450df5dd7d9c4a298 Cr-Commit-Position: refs/heads/master@{#368364}

Patch Set 1 #

Patch Set 2 : Merged to ToT #

Unified diffs Side-by-side diffs Stats (+9 lines, -1 line)
M third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp View 3 chunks +6 lines, -1 line 0 comments
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 1 chunk +3 lines, -0 lines 0 comments

Messages

Total messages: 14 (7 generated)
adamk
4 years, 11 months ago (2016-01-07 20:24:09 UTC) #1
jochen (gone - plz use gerrit)
lgtm
4 years, 11 months ago (2016-01-08 14:13:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566173003/1
4 years, 11 months ago (2016-01-08 16:05:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/133703)
4 years, 11 months ago (2016-01-08 16:12:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566173003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566173003/20001
4 years, 11 months ago (2016-01-08 16:28:06 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-08 17:45:04 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 17:46:06 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/47a491d0b3f398b24aaef13450df5dd7d9c4a298
Cr-Commit-Position: refs/heads/master@{#368364}

Powered by Google App Engine