Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Side by Side Diff: third_party/WebKit/Source/core/frame/UseCounter.cpp

Issue 1566173003: Mark Object.observe as deprecated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merged to ToT Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google, Inc. All rights reserved. 2 * Copyright (C) 2012 Google, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 956 matching lines...) Expand 10 before | Expand all | Expand 10 after
967 967
968 case V8TouchEvent_InitTouchEvent_Method: 968 case V8TouchEvent_InitTouchEvent_Method:
969 return replacedWillBeRemoved("'TouchEvent.initTouchEvent'", "the TouchEv ent constructor", 53, "5730982598541312"); 969 return replacedWillBeRemoved("'TouchEvent.initTouchEvent'", "the TouchEv ent constructor", 53, "5730982598541312");
970 970
971 case RTCPeerConnectionCreateAnswerLegacyNoFailureCallback: 971 case RTCPeerConnectionCreateAnswerLegacyNoFailureCallback:
972 return "RTCPeerConnection.CreateAnswer without a failure callback is dep recated. The failure callback will be a required parameter in M50. See https://w ww.chromestatus.com/feature/5663288008376320 for more details"; 972 return "RTCPeerConnection.CreateAnswer without a failure callback is dep recated. The failure callback will be a required parameter in M50. See https://w ww.chromestatus.com/feature/5663288008376320 for more details";
973 973
974 case RTCPeerConnectionCreateOfferLegacyNoFailureCallback: 974 case RTCPeerConnectionCreateOfferLegacyNoFailureCallback:
975 return "RTCPeerConnection.CreateOffer without a failure callback is depr ecated. The failure callback will be a required parameter in M50. See https://ww w.chromestatus.com/feature/5663288008376320 for more details"; 975 return "RTCPeerConnection.CreateOffer without a failure callback is depr ecated. The failure callback will be a required parameter in M50. See https://ww w.chromestatus.com/feature/5663288008376320 for more details";
976 976
977 case ObjectObserve:
978 return willBeRemoved("'Object.observe'", 50, "6147094632988672");
979
977 // Features that aren't deprecated don't have a deprecation message. 980 // Features that aren't deprecated don't have a deprecation message.
978 default: 981 default:
979 return String(); 982 return String();
980 } 983 }
981 } 984 }
982 985
983 void UseCounter::count(CSSParserMode cssParserMode, CSSPropertyID feature) 986 void UseCounter::count(CSSParserMode cssParserMode, CSSPropertyID feature)
984 { 987 {
985 ASSERT(feature >= firstCSSProperty); 988 ASSERT(feature >= firstCSSProperty);
986 ASSERT(feature <= lastUnresolvedCSSProperty); 989 ASSERT(feature <= lastUnresolvedCSSProperty);
(...skipping 27 matching lines...) Expand all
1014 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 1017 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
1015 { 1018 {
1016 // FIXME: We may want to handle stylesheets that have multiple owners 1019 // FIXME: We may want to handle stylesheets that have multiple owners
1017 // https://crbug.com/242125 1020 // https://crbug.com/242125
1018 if (sheetContents && sheetContents->hasSingleOwnerNode()) 1021 if (sheetContents && sheetContents->hasSingleOwnerNode())
1019 return getFrom(sheetContents->singleOwnerDocument()); 1022 return getFrom(sheetContents->singleOwnerDocument());
1020 return 0; 1023 return 0;
1021 } 1024 }
1022 1025
1023 } // namespace blink 1026 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698