Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: ui/base/ime/input_method_log_collector.h

Issue 1566083002: Makes sure the keyboard typing isn't blocked when InputMethod::OnFocus() is not correctly called. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use DumpWithoutCrashing(). Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/ime/input_method_log_collector.h
diff --git a/ui/base/ime/input_method_log_collector.h b/ui/base/ime/input_method_log_collector.h
new file mode 100644
index 0000000000000000000000000000000000000000..7c6946032b9ca58d86fad2bd427e2a55c10b9be1
--- /dev/null
+++ b/ui/base/ime/input_method_log_collector.h
@@ -0,0 +1,29 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef UI_BASE_IME_INPUT_METHOD_LOG_COLLECTOR_H_
+#define UI_BASE_IME_INPUT_METHOD_LOG_COLLECTOR_H_
+
+#include <string>
+#include <vector>
+
+#include "ui/base/ime/ui_base_ime_export.h"
+
+namespace ui {
+
+class UI_BASE_IME_EXPORT InputMethodLogCollector {
+ public:
+ InputMethodLogCollector();
+ virtual ~InputMethodLogCollector();
+ void AddLog(const std::string& log_string);
+ void DumpLogs();
+ void ClearLogs();
+
+ private:
+ std::vector<std::string> logs_;
eroman 2016/01/13 22:27:08 A couple design comments: (1) How about making th
Shu Chen 2016/01/14 07:44:47 Makes sense. I've followed your suggestions.
+};
+
+} // namespace ui
+
+#endif // UI_BASE_IME_INPUT_METHOD_LOG_COLLECTOR_H_

Powered by Google App Engine
This is Rietveld 408576698