Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Side by Side Diff: ui/base/ime/input_method_log_collector.h

Issue 1566083002: Makes sure the keyboard typing isn't blocked when InputMethod::OnFocus() is not correctly called. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use DumpWithoutCrashing(). Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef UI_BASE_IME_INPUT_METHOD_LOG_COLLECTOR_H_
6 #define UI_BASE_IME_INPUT_METHOD_LOG_COLLECTOR_H_
7
8 #include <string>
9 #include <vector>
10
11 #include "ui/base/ime/ui_base_ime_export.h"
12
13 namespace ui {
14
15 class UI_BASE_IME_EXPORT InputMethodLogCollector {
16 public:
17 InputMethodLogCollector();
18 virtual ~InputMethodLogCollector();
19 void AddLog(const std::string& log_string);
20 void DumpLogs();
21 void ClearLogs();
22
23 private:
24 std::vector<std::string> logs_;
eroman 2016/01/13 22:27:08 A couple design comments: (1) How about making th
Shu Chen 2016/01/14 07:44:47 Makes sense. I've followed your suggestions.
25 };
26
27 } // namespace ui
28
29 #endif // UI_BASE_IME_INPUT_METHOD_LOG_COLLECTOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698