Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: components/autofill/browser/autofill_external_delegate_unittest.cc

Issue 15660018: [autofill] Add support for PSL domain matching for password autofill. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments from isherman and aurimas Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/browser/autofill_external_delegate_unittest.cc
diff --git a/components/autofill/browser/autofill_external_delegate_unittest.cc b/components/autofill/browser/autofill_external_delegate_unittest.cc
index 4554844815ef29589fb0529c420ffd38126e5735..80ae7618771a39b3be59af3ec5a7a9fc5fe1861c 100644
--- a/components/autofill/browser/autofill_external_delegate_unittest.cc
+++ b/components/autofill/browser/autofill_external_delegate_unittest.cc
@@ -267,8 +267,11 @@ TEST_F(AutofillExternalDelegateUnitTest,
// suggestions.
TEST_F(AutofillExternalDelegateUnitTest, ExternalDelegatePasswordSuggestions) {
static const base::string16 kUsername = ASCIIToUTF16("username");
+ static const base::string16 kSignonRealm = ASCIIToUTF16("signon_realm");
palmer 2013/06/11 18:55:45 Is this the file to test specific fuzzy matches th
nyquist 2013/06/11 23:54:43 I have now added these tests at the lowest level,
std::vector<base::string16> suggestions;
suggestions.push_back(kUsername);
+ std::vector<base::string16> realms;
+ realms.push_back(kSignonRealm);
FormFieldData field;
field.is_focusable = true;
@@ -291,6 +294,7 @@ TEST_F(AutofillExternalDelegateUnitTest, ExternalDelegatePasswordSuggestions) {
_));
external_delegate_->OnShowPasswordSuggestions(suggestions,
+ realms,
field,
element_bounds);

Powered by Google App Engine
This is Rietveld 408576698