[autofill] Add support for PSL domain matching for password autofill.

components/autofill/browser/autofill_external_delegate_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/compiler_specific.h"
 #include "base/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
@@ skipping 249 matching lines @@
   autofill::GenerateTestAutofillPopup(external_delegate_.get());
 
   EXPECT_CALL(manager_delegate_, HideAutofillPopup());
   external_delegate_->DidEndTextFieldEditing();
 }
 
 // Test that the popup is marked as visible after recieving password
 // suggestions.
 TEST_F(AutofillExternalDelegateUnitTest, ExternalDelegatePasswordSuggestions) {
   static const base::string16 kUsername = ASCIIToUTF16("username");
+  static const base::string16 kSignonRealm = ASCIIToUTF16("signon_realm");

[palmer, 2013/06/11 18:55:45]

Is this the file to test specific fuzzy matches that should and should not
match? I'd really like to see some tests for matches that should (functionality)
and should not (security) work.

[nyquist, 2013/06/11 23:54:43]

I have now added these tests at the lowest level, namely in
login_database_unittest.cc

   std::vector<base::string16> suggestions;
   suggestions.push_back(kUsername);
+  std::vector<base::string16> realms;
+  realms.push_back(kSignonRealm);
 
   FormFieldData field;
   field.is_focusable = true;
   field.should_autocomplete = true;
   const gfx::RectF element_bounds;
 
   FormFieldData username_field_data;
   username_field_data.value = kUsername;
   PasswordFormFillData password_form_fill_data;
   password_form_fill_data.basic_data.fields.push_back(username_field_data);
   external_delegate_->AddPasswordFormMapping(field, password_form_fill_data);
 
   // The enums must be cast to ints to prevent compile errors on linux_rel.
   EXPECT_CALL(manager_delegate_,
               ShowAutofillPopup(
                   _, _, _, _,
                   testing::ElementsAre(
                       static_cast<int>(
                            WebAutofillClient::MenuItemIDPasswordEntry)),
                   _));
 
   external_delegate_->OnShowPasswordSuggestions(suggestions,
+                                                realms,
                                                 field,
                                                 element_bounds);
 
   EXPECT_CALL(manager_delegate_, HideAutofillPopup());
 
   // This should trigger a call to hide the popup since
   // we've selected an option.
   external_delegate_->DidAcceptSuggestion(
       suggestions[0],
       WebAutofillClient::MenuItemIDPasswordEntry);
@@ skipping 19 matching lines @@
   EXPECT_CALL(manager_delegate_, HideAutofillPopup());
 
   external_delegate_->OnSuggestionsReturned(kQueryId,
                                             autofill_items,
                                             autofill_items,
                                             autofill_items,
                                             autofill_ids);
 }
 
 }  // namespace autofill