Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: content/public/common/password_form.h

Issue 15660018: [autofill] Add support for PSL domain matching for password autofill. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments from palmer Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/password_form.h
diff --git a/content/public/common/password_form.h b/content/public/common/password_form.h
index 1a70685305b274874b49720e53a4f68c73aa6b28..dac4e051b6651201e94bfa6d9c8c63aa7ee2f08e 100644
--- a/content/public/common/password_form.h
+++ b/content/public/common/password_form.h
@@ -54,6 +54,13 @@ struct CONTENT_EXPORT PasswordForm {
// data from the database, so it must not be empty.
std::string signon_realm;
+ // The "Realm" for the sign-on (scheme, host, port for SCHEME_HTML, and
+ // contains the HTTP realm for dialog-based forms).
+ // This realm is only set if this is not a perfect match for same origin
+ // matching and instead just a domain that matches the same domain using the
+ // PSL.
Ilya Sherman 2013/06/07 23:47:56 This comment still leaves me somewhat uncertain as
Ilya Sherman 2013/06/07 23:47:56 nit: Even in comments, please expand out acronyms
nyquist 2013/06/11 03:36:01 Updated the comment. I hope it is clearer now.
+ std::string original_signon_realm;
+
// The URL (minus query parameters) containing the form. This is the primary
// data used by the PasswordManager to decide (in longest matching prefix
// fashion) whether or not a given PasswordForm result from the database is a
@@ -163,6 +170,10 @@ struct CONTENT_EXPORT PasswordForm {
// When parsing an HTML form, this is not used.
int times_used;
+ // Tracks if this is not a perfect match for same origin matching and instead
+ // just a domain that matches the same origin policy using the PSL domain.
+ bool is_psl_origin_match;
+
PasswordForm();
~PasswordForm();
};

Powered by Google App Engine
This is Rietveld 408576698