[autofill] Add support for PSL domain matching for password autofill.

content/public/common/password_form.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_COMMON_PASSWORD_FORM_H__
 #define CONTENT_PUBLIC_COMMON_PASSWORD_FORM_H__
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 36 matching lines @@
     SCHEME_DIGEST,
     SCHEME_OTHER
   } scheme;
 
   // The "Realm" for the sign-on (scheme, host, port for SCHEME_HTML, and
   // contains the HTTP realm for dialog-based forms).
   // The signon_realm is effectively the primary key used for retrieving
   // data from the database, so it must not be empty.
   std::string signon_realm;
 
+  // The "Realm" for the sign-on (scheme, host, port for SCHEME_HTML, and
+  // contains the HTTP realm for dialog-based forms).
+  // This realm is only set if this is not a perfect match for same origin
+  // matching and instead just a domain that matches the same domain using the
+  // PSL.

[Ilya Sherman, 2013/06/07 23:47:56]

This comment still leaves me somewhat uncertain as to when this field is set and
how exactly it differs from signon_realm.  IMO it would be very helpful to
include some motivating examples in the comment, and also to use slightly
simpler (or less technical/jargon-y) language in the explanation.  (That said,
it might be wise to keep the very technical language as well, for the sake of
precision.)

[Ilya Sherman, 2013/06/07 23:47:56]

nit: Even in comments, please expand out acronyms like "PSL".  Think about
someone reading this code a year from now, who is completely new to the password
autofill code.  Try to phrase things in such a way that the prose will be clear
to such a reader :)

[nyquist, 2013/06/11 03:36:01]

Updated the comment. I hope it is clearer now.

+  std::string original_signon_realm;
+
   // The URL (minus query parameters) containing the form. This is the primary
   // data used by the PasswordManager to decide (in longest matching prefix
   // fashion) whether or not a given PasswordForm result from the database is a
   // good fit for a particular form on a page, so it must not be empty.
   GURL origin;
 
   // The action target of the form. This is the primary data used by the
   // PasswordManager for form autofill; that is, the action of the saved
   // credentials must match the action of the form on the page to be autofilled.
   // If this is empty / not available, it will result in a "restricted"
@@ skipping 89 matching lines @@
 
   // The form type. Not used yet. Please see http://crbug.com/152422
   Type type;
 
   // The number of times that this username/password has been used to
   // authenticate the user.
   //
   // When parsing an HTML form, this is not used.
   int times_used;
 
+  // Tracks if this is not a perfect match for same origin matching and instead
+  // just a domain that matches the same origin policy using the PSL domain.
+  bool is_psl_origin_match;
+
   PasswordForm();
   ~PasswordForm();
 };
 
 // Map username to PasswordForm* for convenience. See password_form_manager.h.
 typedef std::map<string16, PasswordForm*> PasswordFormMap;
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_COMMON_PASSWORD_FORM_H__