components/autofill/browser/autofill_manager.h - Issue 15660018: [autofill] Add support for PSL domain matching for password autofill.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/browser/autofill_manager.h

Issue 15660018: [autofill] Add support for PSL domain matching for password autofill. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updated regexp, sanitized result, escaped form domain and added comments. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/browser/autofill_manager.h

diff --git a/components/autofill/browser/autofill_manager.h b/components/autofill/browser/autofill_manager.h

index 35aa535c0804aece0e602a6742ea86c2f421833c..6f9b6b129b85475457024d71d82e083373d36df7 100644

--- a/components/autofill/browser/autofill_manager.h

+++ b/components/autofill/browser/autofill_manager.h

@@ -252,7 +252,8 @@ class AutofillManager : public content::WebContentsObserver,

void OnShowPasswordSuggestions(

const FormFieldData& field,

const gfx::RectF& bounds,

- const std::vector<base::string16>& suggestions);

+ const std::vector<base::string16>& suggestions,

+ const std::vector<base::string16>& origins);

Ilya Sherman 2013/06/06 09:25:35 origins or realms?

nyquist 2013/06/07 22:51:10 Done.

void OnSetDataList(const std::vector<base::string16>& values,

const std::vector<base::string16>& labels,

const std::vector<base::string16>& icons,