Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/autofill/browser/autofill_manager.cc

Issue 15660018: [autofill] Add support for PSL domain matching for password autofill. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updated regexp, sanitized result, escaped form domain and added comments. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/autofill/browser/autofill_manager.h ('K') | « components/autofill/browser/autofill_manager.h ('k') | components/autofill/browser/password_autofill_manager.cc » ('j') | components/autofill/common/password_form_fill_data.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/browser/autofill_manager.cc
diff --git a/components/autofill/browser/autofill_manager.cc b/components/autofill/browser/autofill_manager.cc
index a8ebecd48a0bb578c2b2232aaf930fa28a91a2ee..1d411fb0e234e0b5794229b5668232552191fa8a 100644
--- a/components/autofill/browser/autofill_manager.cc
+++ b/components/autofill/browser/autofill_manager.cc
@@ -754,9 +754,13 @@ void AutofillManager::OnAddPasswordFormMapping(
void AutofillManager::OnShowPasswordSuggestions(
const FormFieldData& field,
const gfx::RectF& bounds,
- const std::vector<base::string16>& suggestions) {
+ const std::vector<base::string16>& suggestions,
+ const std::vector<base::string16>& origins) {
if (external_delegate_)
- external_delegate_->OnShowPasswordSuggestions(suggestions, field, bounds);
+ external_delegate_->OnShowPasswordSuggestions(suggestions,
+ origins,
+ field,
+ bounds);
Ilya Sherman 2013/06/06 09:25:35 nit: Needs curlies now.
nyquist 2013/06/07 22:51:10 Done.
}
void AutofillManager::OnSetDataList(const std::vector<base::string16>& values,
« components/autofill/browser/autofill_manager.h ('K') | « components/autofill/browser/autofill_manager.h ('k') | components/autofill/browser/password_autofill_manager.cc » ('j') | components/autofill/common/password_form_fill_data.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698