Reporing invalid CSS selectors.

Reporing invalid CSS selectors.

It seems that anything not starting with "@" looks like a selector for the parser. I don't report warning in at-rules yet.
However I added error type in advance InvalidRuleError to make visible if something reduces by "invalid_rule" instead of "invalid_at".

BUG=140608
R=apavlov@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151101

[apavlov, 2013-05-23 10:47:06]

https://codereview.chromium.org/15660004/diff/2001/LayoutTests/inspector/cons...
File LayoutTests/inspector/console/console-css-warnings-expected.txt (right):

https://codereview.chromium.org/15660004/diff/2001/LayoutTests/inspector/cons...
LayoutTests/inspector/console/console-css-warnings-expected.txt:21: Invalid CSS
selector: x, console-css-warnings.html:81
optional: You could append new test cases to the existing ones, so that you
wouldn't have to update the line numbers in the existing expectations.

https://codereview.chromium.org/15660004/diff/2001/Source/core/css/CSSGrammar...
File Source/core/css/CSSGrammar.y.in (right):

https://codereview.chromium.org/15660004/diff/2001/Source/core/css/CSSGrammar...
Source/core/css/CSSGrammar.y.in:1553:
exprSourceLocation.content.trimTrailingWhitespace();
Can we perform the trimming in parser->reportError(), depending on the error
type, for example? This snippet doesn't really fit here...

https://codereview.chromium.org/15660004/diff/2001/Source/core/css/CSSGrammar...
Source/core/css/CSSGrammar.y.in:1916: error rule_error_recovery {
parser->endInvalidRuleHeader(); } invalid_block {
We prefer to avoid actions in the middle - can you extract it into a rule,
something like end_invalid_rule_header?

[SeRya, 2013-05-23 15:02:36]

https://codereview.chromium.org/15660004/diff/2001/LayoutTests/inspector/cons...
File LayoutTests/inspector/console/console-css-warnings-expected.txt (right):

https://codereview.chromium.org/15660004/diff/2001/LayoutTests/inspector/cons...
LayoutTests/inspector/console/console-css-warnings-expected.txt:21: Invalid CSS
selector: x, console-css-warnings.html:81
On 2013/05/23 10:47:07, apavlov wrote:
> optional: You could append new test cases to the existing ones, so that you
> wouldn't have to update the line numbers in the existing expectations.

I intentionally keep simple test at the end of the stylesheet. In case something
is eaten up it'll be clear.

https://codereview.chromium.org/15660004/diff/2001/Source/core/css/CSSGrammar...
File Source/core/css/CSSGrammar.y.in (right):

https://codereview.chromium.org/15660004/diff/2001/Source/core/css/CSSGrammar...
Source/core/css/CSSGrammar.y.in:1553:
exprSourceLocation.content.trimTrailingWhitespace();
On 2013/05/23 10:47:07, apavlov wrote:
> Can we perform the trimming in parser->reportError(), depending on the error
> type, for example? This snippet doesn't really fit here...

Done.

https://codereview.chromium.org/15660004/diff/2001/Source/core/css/CSSGrammar...
Source/core/css/CSSGrammar.y.in:1916: error rule_error_recovery {
parser->endInvalidRuleHeader(); } invalid_block {
On 2013/05/23 10:47:07, apavlov wrote:
> We prefer to avoid actions in the middle - can you extract it into a rule,
> something like end_invalid_rule_header?

Done.

[apavlov, 2013-05-24 08:46:44]

Please fix the grammar rule name, and we'll be good to land

https://codereview.chromium.org/15660004/diff/21001/Source/core/css/CSSGramma...
File Source/core/css/CSSGrammar.y.in (right):

https://codereview.chromium.org/15660004/diff/21001/Source/core/css/CSSGramma...
Source/core/css/CSSGrammar.y.in:1920: at_invalid_rule_reader_end:
reader -> header

https://codereview.chromium.org/15660004/diff/21001/Source/core/css/CSSParser...
File Source/core/css/CSSParser.cpp (right):

https://codereview.chromium.org/15660004/diff/21001/Source/core/css/CSSParser...
Source/core/css/CSSParser.cpp:10962: if (is8BitSource())
It's unfortunate that we always have to do this. AFAIU, we don't have any
alternatives...

[SeRya, 2013-05-24 08:57:39]

https://codereview.chromium.org/15660004/diff/21001/Source/core/css/CSSGramma...
File Source/core/css/CSSGrammar.y.in (right):

https://codereview.chromium.org/15660004/diff/21001/Source/core/css/CSSGramma...
Source/core/css/CSSGrammar.y.in:1920: at_invalid_rule_reader_end:
On 2013/05/24 08:46:44, apavlov wrote:
> reader -> header

Done.

[apavlov, 2013-05-24 09:03:22]

lgtm

[commit-bot: I haz the power, 2013-05-24 09:03:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/serya@chromium.org/15660004/27001

[commit-bot: I haz the power, 2013-05-24 10:32:06]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-05-24 11:03:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/serya@chromium.org/15660004/27001

[commit-bot: I haz the power, 2013-05-24 12:20:47]

Retried try job too often on mac_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...

[commit-bot: I haz the power, 2013-05-24 12:32:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/serya@chromium.org/15660004/27001

[commit-bot: I haz the power, 2013-05-24 13:44:13]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[SeRya, 2013-05-24 14:21:04]

Committed patchset #3 manually as r151101 (presubmit successful).