Reporing invalid CSS selectors.

Source/core/css/CSSGrammar.y.in

 /*
  *  Copyright (C) 2002-2003 Lars Knoll (knoll@kde.org)
  *  Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
  *  Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *  Copyright (C) 2008 Eric Seidel <eric@webkit.org>
  *  Copyright (C) 2012 Intel Corporation. All rights reserved.
  *
  *  This library is free software; you can redistribute it and/or
  *  modify it under the terms of the GNU Lesser General Public
  *  License as published by the Free Software Foundation; either
@@ skipping 1531 matching lines @@
     |
     property ':' maybe_space error_location expr prio {
         $$ = false;
         bool isPropertyParsed = false;
         if ($1 && $5) {
             parser->m_valueList = parser->sinkFloatingValueList($5);
             int oldParsedProperties = parser->m_parsedProperties.size();
             $$ = parser->parseValue(static_cast<CSSPropertyID>($1), $6);
             if (!$$) {
                 parser->rollbackLastProperties(parser->m_parsedProperties.size() - oldParsedProperties);
-                parser->reportError(parser->getSource($4, parser->currentLocation()).trimTrailingWhitespace(), CSSParser::InvalidPropertyValueError);
+                CSSParserLocation exprSourceLocation = parser->getSource($4, parser->currentLocation());
+                exprSourceLocation.content.trimTrailingWhitespace();

[apavlov, 2013/05/23 10:47:07]

Can we perform the trimming in parser->reportError(), depending on the error
type, for example? This snippet doesn't really fit here...

[SeRya, 2013/05/23 15:02:37]

Done.

+                parser->reportError(exprSourceLocation, CSSParser::InvalidPropertyValueError);
             } else
                 isPropertyParsed = true;
             parser->m_valueList = nullptr;
         }
         parser->endProperty($6, isPropertyParsed);
     }
     |
     property declaration_recovery {
         parser->endProperty(false, false, CSSParser::GeneralError);
         $$ = false;
@@ skipping 341 matching lines @@
         $$ = 0;
     }
     ;
 
 at_rule_recovery:
     error ';'
   | error invalid_block
     ;
 
 invalid_rule:
-    error rule_error_recovery invalid_block {
+    error rule_error_recovery { parser->endInvalidRuleHeader(); } invalid_block {

[apavlov, 2013/05/23 10:47:07]

We prefer to avoid actions in the middle - can you extract it into a rule,
something like end_invalid_rule_header?

[SeRya, 2013/05/23 15:02:37]

Done.

+        parser->resumeErrorLogging();
         $$ = 0;
     }
     ;
 
 invalid_block:
     '{' error_recovery closing_brace {
         parser->invalidBlockHit();
     }
     ;
 
@@ skipping 24 matching lines @@
 
 rule_error_recovery:
     /* empty */
   | rule_error_recovery error
   | rule_error_recovery invalid_square_brackets_block
   | rule_error_recovery invalid_parentheses_block
     ;
 
 %%