Bug Fix: WebMediaPlayerMS Crashes

content/renderer/media/webmediaplayer_ms_compositor.h

Index: content/renderer/media/webmediaplayer_ms_compositor.h
diff --git a/content/renderer/media/webmediaplayer_ms_compositor.h b/content/renderer/media/webmediaplayer_ms_compositor.h
index 884a003e181df622b93cb6e773b7e4b82ce73381..7050aca09c620855ad98169f66935ed57b16dc2c 100644
--- a/content/renderer/media/webmediaplayer_ms_compositor.h
+++ b/content/renderer/media/webmediaplayer_ms_compositor.h
@@ -48,7 +48,9 @@ class WebMediaPlayerMS;
 // Otherwise, WebMediaPlayerMSCompositor will simply store the most recent
 // frame, and submit it whenever asked by the compositor.
 class CONTENT_EXPORT WebMediaPlayerMSCompositor
-    : public NON_EXPORTED_BASE(cc::VideoFrameProvider) {
+    : public NON_EXPORTED_BASE(cc::VideoFrameProvider),
+      public NON_EXPORTED_BASE(
+          base::SupportsWeakPtr<WebMediaPlayerMSCompositor>) {

[DaleCurtis, 2016/01/07 21:05:46]

Instead of using SupportsWeakPtr, can you just add a WeakFactory member? That's
the preferred pattern for small use cases like this. It prevents external
classes from taking a weakptr unnecessarily.

[qiangchen, 2016/01/08 17:10:12]

Done.

  public:
   // This |url| represents the media stream we are rendering. |url| is used to
   // find out what web stream this WebMediaPlayerMSCompositor is playing, and