content/renderer/media/webmediaplayer_ms_compositor.cc - Issue 1565893002: Bug Fix: WebMediaPlayerMS Crashes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webmediaplayer_ms_compositor.cc

Issue 1565893002: Bug Fix: WebMediaPlayerMS Crashes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Still destroy WMPMSCompositor on compositor thread for clean up work safety. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/webmediaplayer_ms_compositor.cc

diff --git a/content/renderer/media/webmediaplayer_ms_compositor.cc b/content/renderer/media/webmediaplayer_ms_compositor.cc

index ae58a3e3cf6400cc4ea55ad5cc207a0114bd8f53..c61fd0d78bba4a24aa2ae045b76e56bb224f0fc1 100644

--- a/content/renderer/media/webmediaplayer_ms_compositor.cc

+++ b/content/renderer/media/webmediaplayer_ms_compositor.cc

@@ -272,7 +272,7 @@ void WebMediaPlayerMSCompositor::StartRendering() {

DCHECK(thread_checker_.CalledOnValidThread());

compositor_task_runner_->PostTask(

FROM_HERE, base::Bind(&WebMediaPlayerMSCompositor::StartRenderingInternal,

- base::Unretained(this)));

+ AsWeakPtr()));

}

void WebMediaPlayerMSCompositor::StartRenderingInternal() {

@@ -287,7 +287,7 @@ void WebMediaPlayerMSCompositor::StopRendering() {

DCHECK(thread_checker_.CalledOnValidThread());

compositor_task_runner_->PostTask(

FROM_HERE, base::Bind(&WebMediaPlayerMSCompositor::StopRenderingInternal,

- base::Unretained(this)));

+ AsWeakPtr()));

}

void WebMediaPlayerMSCompositor::StopRenderingInternal() {