Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2110)

Unified Diff: net/quic/quic_packet_generator.cc

Issue 1565883003: relnote: Moving many QUIC DFATALS over to QUIC_BUG (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add unused flag to keep code consistent Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_packet_generator.cc
diff --git a/net/quic/quic_packet_generator.cc b/net/quic/quic_packet_generator.cc
index 00293a18b90c5b1b8b0bffe9361d979c241f4c4c..50d6af11eb01cf73abce4e7ebcbb840811346167 100644
--- a/net/quic/quic_packet_generator.cc
+++ b/net/quic/quic_packet_generator.cc
@@ -5,6 +5,7 @@
#include "net/quic/quic_packet_generator.h"
#include "base/logging.h"
+#include "net/quic/quic_bug_tracker.h"
#include "net/quic/quic_fec_group.h"
#include "net/quic/quic_flags.h"
#include "net/quic/quic_utils.h"
@@ -84,7 +85,7 @@ void QuicPacketGenerator::SetShouldSendAck(bool also_send_stop_waiting) {
}
if (also_send_stop_waiting && packet_creator_.has_stop_waiting()) {
- LOG(DFATAL) << "Should only ever be one pending stop waiting frame.";
+ QUIC_BUG << "Should only ever be one pending stop waiting frame.";
return;
}
@@ -120,7 +121,7 @@ QuicConsumedData QuicPacketGenerator::ConsumeData(
}
if (!fin && (iov.total_length == 0)) {
- LOG(DFATAL) << "Attempt to consume empty data without FIN.";
+ QUIC_BUG << "Attempt to consume empty data without FIN.";
return QuicConsumedData(0, false);
}
@@ -132,7 +133,7 @@ QuicConsumedData QuicPacketGenerator::ConsumeData(
has_handshake, &frame, fec_protection)) {
// The creator is always flushed if there's not enough room for a new
// stream frame before ConsumeData, so ConsumeData should always succeed.
- LOG(DFATAL) << "Failed to ConsumeData, stream:" << id;
+ QUIC_BUG << "Failed to ConsumeData, stream:" << id;
return QuicConsumedData(0, false);
}
@@ -231,7 +232,7 @@ void QuicPacketGenerator::SendQueuedFrames(bool flush, bool is_fec_timeout) {
void QuicPacketGenerator::OnFecTimeout() {
DCHECK(!InBatchMode());
if (!packet_creator_.ShouldSendFec(true)) {
- LOG(DFATAL) << "No FEC packet to send on FEC timeout.";
+ QUIC_BUG << "No FEC packet to send on FEC timeout.";
return;
}
// Flush out any pending frames in the generator and the creator, and then

Powered by Google App Engine
This is Rietveld 408576698