net/quic/quic_bug_tracker.h - Issue 1565883003: relnote: Moving many QUIC DFATALS over to QUIC_BUG

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_bug_tracker.h

Issue 1565883003: relnote: Moving many QUIC DFATALS over to QUIC_BUG (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add unused flag to keep code consistent Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/quic_bug_tracker.h

diff --git a/net/quic/quic_bug_tracker.h b/net/quic/quic_bug_tracker.h

new file mode 100644

index 0000000000000000000000000000000000000000..a832aed4ec7545b60c8f90b2cc755bbacd7e8747

--- /dev/null

+++ b/net/quic/quic_bug_tracker.h

@@ -0,0 +1,15 @@

+// // Use of this source code is governed by a BSD-style license that can be

+// // found in the LICENSE file.

Ryan Hamilton 2016/01/07 00:36:13 Remove the extra //?

Zhongyi Shi 2016/01/07 00:45:56 Done.

+#ifndef NET_QUIC_QUIC_BUG_TRACKER_H_

+#define NET_QUIC_QUIC_BUG_TRACKER_H_

+// For external QUIC, QUIC_BUG should be #defined to LOG(DFATAL) as client-side

+// log rate limiting is less important and chrome doesn't LOG_FIRST_N anyway.

+//

+// This file should change infrequently if ever, so update cost should be

+// minimal. Meanwhile we do want different macros so we can rate limit server

+// side, so the google3 shared code increments GFE varz, and chrome can have its

+// own custom hooks.

Ryan Hamilton 2016/01/07 00:36:14 Please remove these comments as they're basically

Zhongyi Shi 2016/01/07 00:45:56 Done.

+#define QUIC_BUG LOG(DFATAL)

+#endif // NET_QUIC_QUIC_BUG_TRACKER_H_

« no previous file with comments | « net/quic/crypto/quic_crypto_client_config.cc ('k') | net/quic/quic_connection.cc » ('j') | no next file with comments »