Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: fpdfsdk/include/pdfwindow/PWL_Wnd.h

Issue 1565803003: Return const-ref object in a few CPWL_Wnd getters. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: remove dead code Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/include/pdfwindow/PWL_Utils.h ('k') | fpdfsdk/src/pdfwindow/PWL_Utils.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/include/pdfwindow/PWL_Wnd.h
diff --git a/fpdfsdk/include/pdfwindow/PWL_Wnd.h b/fpdfsdk/include/pdfwindow/PWL_Wnd.h
index 0ea48b570dfc71ac26de2c5873fdf5bd307b4d5a..4f59fc3d9212bb87c27e66ae15df558c0f57b0af 100644
--- a/fpdfsdk/include/pdfwindow/PWL_Wnd.h
+++ b/fpdfsdk/include/pdfwindow/PWL_Wnd.h
@@ -294,7 +294,6 @@ class CPWL_Wnd : public CPWL_TimerHandler {
void Move(const CPDF_Rect& rcNew, FX_BOOL bReset, FX_BOOL bRefresh);
virtual void InvalidateRect(CPDF_Rect* pRect = NULL);
- void GetAppearanceStream(CFX_ByteString& sAppStream);
void DrawAppearance(CFX_RenderDevice* pDevice, CFX_Matrix* pUser2Device);
virtual FX_BOOL OnKeyDown(FX_WORD nChar, FX_DWORD nFlag);
@@ -341,27 +340,21 @@ class CPWL_Wnd : public CPWL_TimerHandler {
virtual void SetFontSize(FX_FLOAT fFontSize);
void SetBackgroundColor(const CPWL_Color& color);
- void SetBorderColor(const CPWL_Color& color);
- void SetBorderWidth(int32_t nBorderWidth);
void SetClipRect(const CPDF_Rect& rect);
void SetBorderStyle(int32_t eBorderStyle);
- void SetBorderDash(const CPWL_Dash& sDash);
- CPDF_Rect GetOriginWindowRect() const;
virtual CPDF_Rect GetWindowRect() const;
virtual CPDF_Rect GetClientRect() const;
CPDF_Point GetCenterPoint() const;
- CPDF_Rect GetClientCenterSquare() const;
- CPDF_Rect GetWindowCenterSquare() const;
int32_t GetBorderWidth() const;
FX_BOOL IsVisible() const { return m_bVisible; }
FX_BOOL HasFlag(FX_DWORD dwFlags) const;
void AddFlag(FX_DWORD dwFlags);
void RemoveFlag(FX_DWORD dwFlags);
- CPDF_Rect GetClipRect() const;
+ const CPDF_Rect& GetClipRect() const;
CPWL_Wnd* GetParentWindow() const;
int32_t GetBorderStyle() const;
- CPWL_Dash GetBorderDash() const;
+ const CPWL_Dash& GetBorderDash() const;
void* GetAttachedData() const;
FX_BOOL WndHitTest(const CPDF_Point& point) const;
@@ -427,7 +420,7 @@ class CPWL_Wnd : public CPWL_TimerHandler {
void SetNotifyFlag(FX_BOOL bNotifying = TRUE) { m_bNotifying = bNotifying; }
FX_BOOL IsValid() const;
- PWL_CREATEPARAM GetCreationParam() const;
+ const PWL_CREATEPARAM& GetCreationParam() const;
FX_BOOL IsNotifying() const { return m_bNotifying; }
void InvalidateRectMove(const CPDF_Rect& rcOld, const CPDF_Rect& rcNew);
« no previous file with comments | « fpdfsdk/include/pdfwindow/PWL_Utils.h ('k') | fpdfsdk/src/pdfwindow/PWL_Utils.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698